public inbox for libc-ports@sourceware.org
 help / color / mirror / Atom feed
From: "Joseph S. Myers" <joseph@codesourcery.com>
To: <libc-ports@sourceware.org>
Subject: Fix warnings from MIPS soft-float _FPU_GETCW
Date: Tue, 04 Dec 2012 22:08:00 -0000	[thread overview]
Message-ID: <Pine.LNX.4.64.1212042207210.17916@digraph.polyomino.org.uk> (raw)

Testing for MIPS soft-float showed up compile warnings ("statement
with no effect") in setfpucw.c arising from the soft-float definition
of _FPU_GETCW just being "0".  I've applied this patch to make the
definition actually store 0 in cw, and correspondingly to make
_FPU_SETCW use cw by casting the value to (void), to make these
soft-float definitions better at avoiding warnings from use using
these macros.

2012-12-04  Joseph Myers  <joseph@codesourcery.com>

	* sysdeps/mips/fpu_control.h [__mips_soft_float] (_FPU_GETCW):
	Define to set cw to 0, now just to plain "0" as a statement.
	[__mips_soft_float] (_FPU_SETCW): Define to (void) (cw), rather
	than doing nothing with cw.

diff --git a/ports/sysdeps/mips/fpu_control.h b/ports/sysdeps/mips/fpu_control.h
index 7307d03..acf794c 100644
--- a/ports/sysdeps/mips/fpu_control.h
+++ b/ports/sysdeps/mips/fpu_control.h
@@ -1,6 +1,5 @@
 /* FPU control word bits.  Mips version.
-   Copyright (C) 1996, 1997, 1998, 1999, 2000, 2006, 2008
-   Free Software Foundation, Inc.
+   Copyright (C) 1996-2012 Free Software Foundation, Inc.
    This file is part of the GNU C Library.
    Contributed by Olaf Flebbe and Ralf Baechle.
 
@@ -63,8 +62,8 @@
 #define _FPU_RESERVED 0xffffffff
 #define _FPU_DEFAULT  0x00000000
 typedef unsigned int fpu_control_t;
-#define _FPU_GETCW(cw) 0
-#define _FPU_SETCW(cw) do { } while (0)
+#define _FPU_GETCW(cw) (cw) = 0
+#define _FPU_SETCW(cw) (void) (cw)
 extern fpu_control_t __fpu_control;
 
 #else /* __mips_soft_float */

-- 
Joseph S. Myers
joseph@codesourcery.com

             reply	other threads:[~2012-12-04 22:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-04 22:08 Joseph S. Myers [this message]
2012-12-05 15:15 ` Chris Metcalf
2012-12-05 15:23   ` Joseph S. Myers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.1212042207210.17916@digraph.polyomino.org.uk \
    --to=joseph@codesourcery.com \
    --cc=libc-ports@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).