From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29808 invoked by alias); 23 Jan 2013 17:06:33 -0000 Received: (qmail 29791 invoked by uid 22791); 23 Jan 2013 17:06:31 -0000 X-SWARE-Spam-Status: No, hits=-4.8 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 23 Jan 2013 17:06:27 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1Ty3mM-00070r-LT from joseph_myers@mentor.com for libc-ports@sourceware.org; Wed, 23 Jan 2013 09:06:26 -0800 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Wed, 23 Jan 2013 09:06:26 -0800 Received: from digraph.polyomino.org.uk (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.1.289.1; Wed, 23 Jan 2013 17:06:24 +0000 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.76) (envelope-from ) id 1Ty3mJ-0002QI-Ow; Wed, 23 Jan 2013 17:06:23 +0000 Date: Wed, 23 Jan 2013 17:06:00 -0000 From: "Joseph S. Myers" To: "Maciej W. Rozycki" CC: Subject: Re: [PATCH][BZ #15054] MIPS: Fix syscall wrappers for syscall restart support In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org X-SW-Source: 2013-01/txt/msg00044.txt.bz2 On Wed, 23 Jan 2013, Maciej W. Rozycki wrote: > +#ifdef __mips_micromips > +#define MOVE32 "move32" > +#else > +#define MOVE32 "move" > +#endif Indent preprocessor directives inside #if, so "# define", here and in the other instances of this code in the patch. > + register long __s0 asm("$16") __attribute__((unused)) = number; \ Space between __attribute__ and ((unused)), everywhere this construct appears in this patch. OK with those whitespace fixes; remember to update the list of fixed bugs in the NEWS file (a single list is used for both libc and ports bugs) as part of your commit of the fix, and to close the bug as fixed afterwards. -- Joseph S. Myers joseph@codesourcery.com