From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13149 invoked by alias); 24 Jan 2013 16:31:02 -0000 Received: (qmail 13123 invoked by uid 22791); 24 Jan 2013 16:30:58 -0000 X-SWARE-Spam-Status: No, hits=-4.8 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 24 Jan 2013 16:30:52 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1TyPhT-0002Ui-VE from joseph_myers@mentor.com for libc-ports@sourceware.org; Thu, 24 Jan 2013 08:30:51 -0800 Received: from SVR-IES-FEM-03.mgc.mentorg.com ([137.202.0.108]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Thu, 24 Jan 2013 08:30:51 -0800 Received: from digraph.polyomino.org.uk (137.202.0.76) by SVR-IES-FEM-03.mgc.mentorg.com (137.202.0.108) with Microsoft SMTP Server id 14.1.289.1; Thu, 24 Jan 2013 16:30:49 +0000 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.76) (envelope-from ) id 1TyPhQ-0008PV-7J; Thu, 24 Jan 2013 16:30:48 +0000 Date: Thu, 24 Jan 2013 16:31:00 -0000 From: "Joseph S. Myers" To: "Maciej W. Rozycki" CC: Subject: Re: [PATCH][BZ #15054] MIPS: Fix syscall wrappers for syscall restart support In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org X-SW-Source: 2013-01/txt/msg00051.txt.bz2 On Thu, 24 Jan 2013, Maciej W. Rozycki wrote: > > > + register long __s0 asm("$16") __attribute__((unused)) = number; \ > > > > Space between __attribute__ and ((unused)), everywhere this construct > > appears in this patch. > > Oops, sorry about this oversight -- presumably there needs to be a space > between asm and () as well, right? It looks like we don't respect this > requirement at all right now throughout the files concerned. Yes, there should be such a space for asm as well. -- Joseph S. Myers joseph@codesourcery.com