From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25828 invoked by alias); 19 Feb 2013 17:18:32 -0000 Received: (qmail 25794 invoked by uid 22791); 19 Feb 2013 17:18:30 -0000 X-SWARE-Spam-Status: No, hits=-4.8 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 19 Feb 2013 17:18:25 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1U7qpj-0000qc-Sb from joseph_myers@mentor.com ; Tue, 19 Feb 2013 09:18:23 -0800 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Tue, 19 Feb 2013 09:18:23 -0800 Received: from digraph.polyomino.org.uk (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.1.289.1; Tue, 19 Feb 2013 17:18:21 +0000 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.76) (envelope-from ) id 1U7qpg-00014N-Lw; Tue, 19 Feb 2013 17:18:20 +0000 Date: Tue, 19 Feb 2013 17:18:00 -0000 From: "Joseph S. Myers" To: Richard Henderson CC: Siddhesh Poyarekar , , Subject: Re: PI mutex support for pthread_cond_* now in nptl In-Reply-To: <5123AB55.2070100@twiddle.net> Message-ID: References: <20130218105637.GJ32163@spoyarek.pnq.redhat.com> <5123AB55.2070100@twiddle.net> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org X-SW-Source: 2013-02/txt/msg00042.txt.bz2 On Tue, 19 Feb 2013, Richard Henderson wrote: > Any chance we can move these macros into a generic linux header? > Given that we're using INTERNAL_SYSCALL macros, the definitions ought to be > the same for all targets. Generally most of lowlevellock.h should probably be shared between architectures. (If some architectures don't implement a particular feature as of a particular kernel version, that's a matter for kernel-features.h and __ASSUME_* conditionals.) There are however two different groups of those headers, those where e.g. lll_futex_timed_wait ends with INTERNAL_SYSCALL_ERROR_P (__ret, __err) ? -__ret : __ret; (e.g. powerpc) and those (e.g. s390) where it just ends with a call to INTERNAL_SYSCALL and relies on the return value of INTERNAL_SYSCALL being the correct return from the macro. I'm not sure whether those differences actually serve a useful purpose or whether the return value of INTERNAL_SYSCALL differs in a relevant way between architectures. -- Joseph S. Myers joseph@codesourcery.com