From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7940 invoked by alias); 20 Feb 2013 16:29:59 -0000 Received: (qmail 7904 invoked by uid 22791); 20 Feb 2013 16:29:57 -0000 X-SWARE-Spam-Status: No, hits=-4.8 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 20 Feb 2013 16:29:50 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1U8CYI-0005vT-04 from joseph_myers@mentor.com ; Wed, 20 Feb 2013 08:29:50 -0800 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Wed, 20 Feb 2013 08:29:49 -0800 Received: from digraph.polyomino.org.uk (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.1.289.1; Wed, 20 Feb 2013 16:29:47 +0000 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.76) (envelope-from ) id 1U8CYE-00087t-DY; Wed, 20 Feb 2013 16:29:46 +0000 Date: Wed, 20 Feb 2013 16:29:00 -0000 From: "Joseph S. Myers" To: "Maciej W. Rozycki" CC: , Chung-Lin Tang , Steve Ellcey , Richard Sandiford Subject: Re: [PATCH v2] MIPS: MIPS16 support In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org X-SW-Source: 2013-02/txt/msg00052.txt.bz2 On Wed, 20 Feb 2013, Maciej W. Rozycki wrote: > * sysdeps/mips/fpu_control.h (__fpu_getcw) [__mips16]: New > prototype. > (__fpu_setcw) [__mips16]: Likewise. Since you've renamed the functions to __mips_fpu_getcw and __mips_fpu_setcw, you need to update the ChangeLog entry accordingly. The ChangeLog entries may also need updates for other changes in this patch version. > * sysdeps/mips/mips32/mips16/fpu/Versions: New file. Actually you moved the Versions file to the correct place for the symbol versions not to depend on whether glibc itself is built as MIPS16. But the contents of the file - and of the libc.abilist changes - need updating for the new symbol names. (Given these inconsistencies, I haven't fully reviewed the rest of the patch contents.) -- Joseph S. Myers joseph@codesourcery.com