From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27968 invoked by alias); 28 Feb 2013 01:03:42 -0000 Received: (qmail 27903 invoked by uid 22791); 28 Feb 2013 01:03:40 -0000 X-SWARE-Spam-Status: No, hits=-4.8 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 28 Feb 2013 01:03:35 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1UAruI-0001Ft-It from joseph_myers@mentor.com ; Wed, 27 Feb 2013 17:03:34 -0800 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Wed, 27 Feb 2013 17:03:34 -0800 Received: from digraph.polyomino.org.uk (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.1.289.1; Thu, 28 Feb 2013 01:03:32 +0000 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.76) (envelope-from ) id 1UAruF-0006mc-JW; Thu, 28 Feb 2013 01:03:31 +0000 Date: Thu, 28 Feb 2013 01:03:00 -0000 From: "Joseph S. Myers" To: Richard Henderson CC: Subject: Re: [PATCH 14/26] arm: Use push/pop mnemonics In-Reply-To: <1361934986-17018-15-git-send-email-rth@twiddle.net> Message-ID: References: <1361934986-17018-1-git-send-email-rth@twiddle.net> <1361934986-17018-15-git-send-email-rth@twiddle.net> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org X-SW-Source: 2013-02/txt/msg00129.txt.bz2 On Tue, 26 Feb 2013, Richard Henderson wrote: > For arm this makes no difference--the result is bit-for-bit identical; > for thumb this results in smaller encodings. Perhaps it ought not and > this is in fact an assembler bug, but I also think it's clearer. > --- > * sysdeps/arm/arm-mcount.S (_mcount): Use push/pop mnemonics. > * sysdeps/arm/crti.S, sysdeps/arm/crtn.S: Likewise. > * sysdeps/arm/dl-tlsdesc.S: Likewise. > * sysdeps/arm/dl-trampoline.S: Likewise. > * sysdeps/arm/start.S: Likewise. > * sysdeps/arm/memcpy.S (PULL): Rename macro from pull. > (PUSH): Rename macro from push. > (memcpy): Use push/pop mnemonics. > * sysdeps/arm/memmove.S: Similarly. > * sysdeps/arm/sysdep.h (CALL_MCOUNT): Use push/pop mnemonics. > * sysdeps/unix/sysv/linux/arm/____longjmp_chk.S: Likewise. > * sysdeps/unix/sysv/linux/arm/clone.S: Likewise. > * sysdeps/unix/sysv/linux/arm/mmap.S: Likewise. > * sysdeps/unix/sysv/linux/arm/mmap64.S: Likewise. > * sysdeps/unix/sysv/linux/arm/nptl/sysdep-cancel.h: Likewise. > * sysdeps/unix/sysv/linux/arm/nptl/unwind-forcedunwind.c: Likewise. > * sysdeps/unix/sysv/linux/arm/nptl/unwind-resume.c: Likewise. > * sysdeps/unix/sysv/linux/arm/syscall.S: Likewise. > * sysdeps/unix/sysv/linux/arm/sysdep.h: Likewise. > * sysdeps/unix/sysv/linux/arm/vfork.S: Likewise. OK. -- Joseph S. Myers joseph@codesourcery.com