From: "Joseph S. Myers" <joseph@codesourcery.com>
To: Roland McGrath <roland@hack.frob.com>
Cc: <libc-ports@sourceware.org>
Subject: Re: [PATCH roland/arm-avoid-r9] ARM: Use r10 instead of r9.
Date: Thu, 28 Feb 2013 21:23:00 -0000 [thread overview]
Message-ID: <Pine.LNX.4.64.1302282122060.9171@digraph.polyomino.org.uk> (raw)
In-Reply-To: <20130228211607.597EC2C0A5@topped-with-meat.com>
On Thu, 28 Feb 2013, Roland McGrath wrote:
> > looks like it should be r5-r8, r10. How was this patch tested?
>
> Oops, I caught most of those cases but missed the last couple.
> Now fixed on the branch.
>
> I haven't done any testing at all yet. I wanted to make sure you didn't
> have some broader objection to the change before I dealt with getting set
> up to do arm-linux-gnueabi builds and test runs. If you're not willing to
> approve on eyeball validation alone (which is eminently reasonable, of
> course), then I'll get my testing setup in order before asking again.
I think the principle is fine, but this does need testing as illustrated
by the above issue. (Unlike Richard's whole new implementations of some
string functions, I don't think there's any need for big-endian testing
here; testing for just one endianness suffices.)
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2013-02-28 21:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-28 1:01 Roland McGrath
2013-02-28 16:54 ` Joseph S. Myers
2013-02-28 21:16 ` Roland McGrath
2013-02-28 21:23 ` Joseph S. Myers [this message]
2013-03-11 18:07 Roland McGrath
2013-03-11 23:35 ` Joseph S. Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.1302282122060.9171@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=libc-ports@sourceware.org \
--cc=roland@hack.frob.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).