From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29247 invoked by alias); 5 Mar 2013 01:42:35 -0000 Received: (qmail 29161 invoked by uid 22791); 5 Mar 2013 01:42:34 -0000 X-SWARE-Spam-Status: No, hits=-4.8 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 05 Mar 2013 01:42:28 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1UCgtf-0005fE-BA from joseph_myers@mentor.com ; Mon, 04 Mar 2013 17:42:27 -0800 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Mon, 4 Mar 2013 17:42:27 -0800 Received: from digraph.polyomino.org.uk (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.1.289.1; Tue, 5 Mar 2013 01:42:25 +0000 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.76) (envelope-from ) id 1UCgtc-0001Hc-HP; Tue, 05 Mar 2013 01:42:24 +0000 Date: Tue, 05 Mar 2013 01:42:00 -0000 From: "Joseph S. Myers" To: Richard Henderson CC: Subject: Re: [PATCH v2 02/14] arm: Introduce and use NEGOFF series of macros In-Reply-To: <1362159320-5934-3-git-send-email-rth@twiddle.net> Message-ID: References: <1362159320-5934-1-git-send-email-rth@twiddle.net> <1362159320-5934-3-git-send-email-rth@twiddle.net> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org X-SW-Source: 2013-03/txt/msg00028.txt.bz2 On Fri, 1 Mar 2013, Richard Henderson wrote: > There are several places in which we access negative offsets from > the thread-pointer, but thumb2 only supports positive offsets in > memory references. > > Avoid duplicating the rather large macros in which these references > are embedded by abstracting out the operation. > --- > * sysdeps/arm/sysdep.h (NEGOFF_ADJ_BASE): New macro. > (NEGOFF_ADJ_BASE2, NEGOFF_OFF1, NEGOFF_OFF2): New macros. > * sysdeps/unix/sysv/linux/arm/clone.S (__clone): Use them. > * sysdeps/unix/sysv/linux/arm/nptl/vfork.S: Likewise. > * sysdeps/unix/sysv/linux/arm/nptl/pt-vfork.S: Likewise. > * sysdeps/unix/sysv/linux/arm/nptl/sysdep-cancel.h (SINGLE_THREAD_P): > Likewise. OK. -- Joseph S. Myers joseph@codesourcery.com