public inbox for libc-ports@sourceware.org
 help / color / mirror / Atom feed
From: "Joseph S. Myers" <joseph@codesourcery.com>
To: Richard Henderson <rth@twiddle.net>
Cc: <libc-ports@sourceware.org>
Subject: Re: [PATCH v2 09/14] arm: Tidy architecture selection
Date: Tue, 05 Mar 2013 02:01:00 -0000	[thread overview]
Message-ID: <Pine.LNX.4.64.1303050146520.32239@digraph.polyomino.org.uk> (raw)
In-Reply-To: <1362159320-5934-10-git-send-email-rth@twiddle.net>

On Fri, 1 Mar 2013, Richard Henderson wrote:

> +# elif defined(__ARM_ARCH_5T__) || defined(__ARM_ARCH_5TE__) \
> +       defined(__ARM_ARCH_5TEJ__)
> +#  define __ARM_ARCH 5

Or plain 5, or 5E (allowed by the architecture and -march=armv5 / 
-march=armv5e, even if GCC doesn't know of any relevant -mcpu= processors 
and such may not have existed).

> +# elif defined(__ARM_ARCH_6J__) || defined(__ARM_ARCH_6ZK__) \
> +       defined(__ARM_ARCH_6K__) || defined(__ARM_ARCH_6T2__)
> +#  define __ARM_ARCH 6

Or plain 6, or 6Z.

My reference for possible values is the union of the architecture columns 
in GCC 4.7's arm-arches.def and arm-cores.def (given that for 4.8 and 
later you have __ARM_ARCH predefined, so only the values known to 4.7 are 
relevant here).

> +# elif defined(__ARM_ARCH_7A__) || defined(__ARM_ARCH_7R__) \
> +       defined(__ARM_ARCH_7M__) || defined(__ARM_ARCH_7EM__)

Or plain 7 (given that you're already covering values that aren't actually 
compatible with building glibc).

OK fixed to handle all the other __ARM_ARCH_* values GCC might define, as 
described above.

-- 
Joseph S. Myers
joseph@codesourcery.com

  parent reply	other threads:[~2013-03-05  2:01 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-01 17:36 [PATCH v2 00/14] ARM improvements Richard Henderson
2013-03-01 17:36 ` [PATCH v2 14/14] arm: Add optimized add_n and sub_n Richard Henderson
2013-03-01 17:59   ` Roland McGrath
2013-03-06  0:53   ` Joseph S. Myers
2013-03-01 17:36 ` [PATCH v2 05/14] arm: Use push/pop mnemonics Richard Henderson
2013-03-01 17:36 ` [PATCH v2 09/14] arm: Tidy architecture selection Richard Henderson
2013-03-01 17:55   ` Roland McGrath
2013-03-05  2:01   ` Joseph S. Myers [this message]
2013-03-01 17:36 ` [PATCH v2 11/14] arm: Add optimized ffs for armv6t2 Richard Henderson
2013-03-05  2:08   ` Joseph S. Myers
2013-03-06 15:52     ` Richard Henderson
2013-03-01 17:36 ` [PATCH v2 13/14] arm: Add optimized submul_1 Richard Henderson
2013-03-01 17:58   ` Roland McGrath
2013-03-06  1:14   ` Joseph S. Myers
2013-03-01 17:36 ` [PATCH v2 06/14] arm: Delete LOADREGS macro Richard Henderson
2013-03-01 17:36 ` [PATCH v2 08/14] arm: Unless arm4t, pop return address directly into pc Richard Henderson
2013-03-01 17:36 ` [PATCH v2 10/14] arm: Implement hard-tp for GET_TLS Richard Henderson
2013-03-01 17:55   ` Roland McGrath
2013-03-05  2:01   ` Joseph S. Myers
2013-03-01 17:36 ` [PATCH v2 03/14] arm: Introduce and use GET_TLS Richard Henderson
2013-03-01 17:57   ` Roland McGrath
2013-03-05  1:45   ` Joseph S. Myers
2013-03-01 17:36 ` [PATCH v2 04/14] arm: Enable thumb2 mode in assembly files Richard Henderson
2013-03-01 17:36 ` [PATCH v2 01/14] arm: Introduce and use LDST_PCREL Richard Henderson
2013-03-04 17:47   ` Joseph S. Myers
2013-03-01 17:36 ` [PATCH v2 12/14] arm: Add optimized addmul_1 Richard Henderson
2013-03-01 17:58   ` Roland McGrath
2013-03-01 18:00   ` Roland McGrath
2013-03-06  1:18     ` Joseph S. Myers
2013-10-25 22:13       ` Roland McGrath
2013-03-06  1:11   ` Joseph S. Myers
2013-03-01 17:36 ` [PATCH v2 02/14] arm: Introduce and use NEGOFF series of macros Richard Henderson
2013-03-01 17:57   ` Roland McGrath
2013-03-05  1:42   ` Joseph S. Myers
2013-03-01 17:36 ` [PATCH v2 07/14] arm: Commonize BX conditionals Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.1303050146520.32239@digraph.polyomino.org.uk \
    --to=joseph@codesourcery.com \
    --cc=libc-ports@sourceware.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).