From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6489 invoked by alias); 5 Mar 2013 02:01:04 -0000 Received: (qmail 6475 invoked by uid 22791); 5 Mar 2013 02:01:02 -0000 X-SWARE-Spam-Status: No, hits=-4.8 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 05 Mar 2013 02:00:58 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1UChBa-0000rf-4Y from joseph_myers@mentor.com ; Mon, 04 Mar 2013 18:00:58 -0800 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Mon, 4 Mar 2013 18:00:57 -0800 Received: from digraph.polyomino.org.uk (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.1.289.1; Tue, 5 Mar 2013 02:00:55 +0000 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.76) (envelope-from ) id 1UChBW-0001S2-N6; Tue, 05 Mar 2013 02:00:54 +0000 Date: Tue, 05 Mar 2013 02:01:00 -0000 From: "Joseph S. Myers" To: Richard Henderson CC: Subject: Re: [PATCH v2 09/14] arm: Tidy architecture selection In-Reply-To: <1362159320-5934-10-git-send-email-rth@twiddle.net> Message-ID: References: <1362159320-5934-1-git-send-email-rth@twiddle.net> <1362159320-5934-10-git-send-email-rth@twiddle.net> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org X-SW-Source: 2013-03/txt/msg00030.txt.bz2 On Fri, 1 Mar 2013, Richard Henderson wrote: > +# elif defined(__ARM_ARCH_5T__) || defined(__ARM_ARCH_5TE__) \ > + defined(__ARM_ARCH_5TEJ__) > +# define __ARM_ARCH 5 Or plain 5, or 5E (allowed by the architecture and -march=armv5 / -march=armv5e, even if GCC doesn't know of any relevant -mcpu= processors and such may not have existed). > +# elif defined(__ARM_ARCH_6J__) || defined(__ARM_ARCH_6ZK__) \ > + defined(__ARM_ARCH_6K__) || defined(__ARM_ARCH_6T2__) > +# define __ARM_ARCH 6 Or plain 6, or 6Z. My reference for possible values is the union of the architecture columns in GCC 4.7's arm-arches.def and arm-cores.def (given that for 4.8 and later you have __ARM_ARCH predefined, so only the values known to 4.7 are relevant here). > +# elif defined(__ARM_ARCH_7A__) || defined(__ARM_ARCH_7R__) \ > + defined(__ARM_ARCH_7M__) || defined(__ARM_ARCH_7EM__) Or plain 7 (given that you're already covering values that aren't actually compatible with building glibc). OK fixed to handle all the other __ARM_ARCH_* values GCC might define, as described above. -- Joseph S. Myers joseph@codesourcery.com