From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15284 invoked by alias); 6 Mar 2013 16:33:55 -0000 Received: (qmail 15276 invoked by uid 22791); 6 Mar 2013 16:33:54 -0000 X-SWARE-Spam-Status: No, hits=-4.8 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 06 Mar 2013 16:33:50 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1UDHHp-0006NP-AW from joseph_myers@mentor.com ; Wed, 06 Mar 2013 08:33:49 -0800 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Wed, 6 Mar 2013 08:33:48 -0800 Received: from digraph.polyomino.org.uk (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.1.289.1; Wed, 6 Mar 2013 16:33:46 +0000 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.76) (envelope-from ) id 1UDHHl-0003Yl-NX; Wed, 06 Mar 2013 16:33:45 +0000 Date: Wed, 06 Mar 2013 16:33:00 -0000 From: "Joseph S. Myers" To: Andreas Jaeger CC: Subject: Re: [PATCH 5/6] Use bits/mman-linux.h for MIPS In-Reply-To: <5137652E.5010803@suse.com> Message-ID: References: <1362512224-26951-1-git-send-email-aj@suse.de> <1362512224-26951-6-git-send-email-aj@suse.de> <3652367.0reEtX4Bp7@byrd> <5137652E.5010803@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org X-SW-Source: 2013-03/txt/msg00056.txt.bz2 On Wed, 6 Mar 2013, Andreas Jaeger wrote: > Here's an updated patch, ok now? > > Andreas > > 2013-03-06 Andreas Jaeger > > * sysdeps/unix/sysv/linux/bits/mman-linux.h (MAP_ANONYMOUS): Allow > definition via __MAP_ANONYMOUS. > > ChangeLog.mips: > * sysdeps/unix/sysv/linux/mips/bits/mman.h: Remove all defines > provided by bits/mman-linux.h and include . > (__MAP_ANONYMOUS): Define. OK. In general I think defining __* names ought to be the right approach for architectures with more substantial differences in the values as well, so that the architecture-specific headers never need to concern themselves with the feature-test macros that determine when to expose non-__* names to the user. -- Joseph S. Myers joseph@codesourcery.com