From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18001 invoked by alias); 12 Mar 2013 23:35:37 -0000 Received: (qmail 17805 invoked by uid 22791); 12 Mar 2013 23:35:34 -0000 X-SWARE-Spam-Status: No, hits=-4.8 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 12 Mar 2013 23:35:28 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1UFYj9-0004OT-TD from joseph_myers@mentor.com ; Tue, 12 Mar 2013 16:35:27 -0700 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Tue, 12 Mar 2013 16:35:27 -0700 Received: from digraph.polyomino.org.uk (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.1.289.1; Tue, 12 Mar 2013 23:35:26 +0000 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.76) (envelope-from ) id 1UFYj7-0005c2-7x; Tue, 12 Mar 2013 23:35:25 +0000 Date: Tue, 12 Mar 2013 23:35:00 -0000 From: "Joseph S. Myers" To: Roland McGrath CC: Subject: Re: [PATCH roland/arm-avoid-pc] ARM: Support avoiding pc as destination register. In-Reply-To: <20130311205410.2A99B2C08D@topped-with-meat.com> Message-ID: References: <20130311205410.2A99B2C08D@topped-with-meat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org X-SW-Source: 2013-03/txt/msg00121.txt.bz2 On Mon, 11 Mar 2013, Roland McGrath wrote: > * sysdeps/arm/arm-features.h: Add comment about ARM_ALWAYS_BX. That's OK. > +#else > + beq 7f > + push {r10} > + cfi_adjust_cfa_offset (4) This should also have cfi_rel_offset (r10, 0) to record the save itself in CFI debug information. > +#ifdef ARM_ALWAYS_BX > + pop {r10} > + cfi_adjust_cfa_offset (-4) > +#endif Likewise, record the restore of r10. > +#else > + beq 7f > + push {r10} > + cfi_adjust_cfa_offset (4) Likewise, in memmove. > +#ifdef ARM_ALWAYS_BX > + pop {r10} > + cfi_adjust_cfa_offset (-4) Likewise. -- Joseph S. Myers joseph@codesourcery.com