From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16444 invoked by alias); 12 Mar 2013 23:40:25 -0000 Received: (qmail 16435 invoked by uid 22791); 12 Mar 2013 23:40:24 -0000 X-SWARE-Spam-Status: No, hits=-4.8 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 12 Mar 2013 23:40:20 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1UFYnr-0004dg-Fn from joseph_myers@mentor.com ; Tue, 12 Mar 2013 16:40:19 -0700 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Tue, 12 Mar 2013 16:40:19 -0700 Received: from digraph.polyomino.org.uk (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.1.289.1; Tue, 12 Mar 2013 23:40:17 +0000 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.76) (envelope-from ) id 1UFYno-0006wV-1L; Tue, 12 Mar 2013 23:40:16 +0000 Date: Tue, 12 Mar 2013 23:40:00 -0000 From: "Joseph S. Myers" To: Roland McGrath CC: Subject: Re: [PATCH roland/arm-avoid-pc] ARM_BX_ALIGN_LOG2 In-Reply-To: <20130311205518.977F12C08D@topped-with-meat.com> Message-ID: References: <20130311205410.2A99B2C08D@topped-with-meat.com> <20130311205518.977F12C08D@topped-with-meat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org X-SW-Source: 2013-03/txt/msg00122.txt.bz2 On Mon, 11 Mar 2013, Roland McGrath wrote: > +/* The log2 of the minimum alignment required for an address that > + is the target of a computed branch (i.e. a "bx" instruction). > + A more-specific arm-features.h file may define this to set a more > + stringent requirement. */ The comment should say that this should only be used in ARM-mode code (certainly this definition doesn't make sense by default for code built as Thumb). OK with that change. -- Joseph S. Myers joseph@codesourcery.com