From: "Joseph S. Myers" <joseph@codesourcery.com>
To: Thomas Schwinge <thomas@codesourcery.com>
Cc: <libc-alpha@sourceware.org>, <libc-ports@sourceware.org>
Subject: Re: Policy question -- libm-test: tests with sNaNs as inputs
Date: Wed, 03 Apr 2013 15:41:00 -0000 [thread overview]
Message-ID: <Pine.LNX.4.64.1304031536570.580@digraph.polyomino.org.uk> (raw)
In-Reply-To: <87ip43zl72.fsf@schwinge.name>
On Wed, 3 Apr 2013, Thomas Schwinge wrote:
> I'd like to propose the following patch, which adds several tests with
> sNaNs as inputs to the libm-test framework.
The tests for hypot are wrong - there, qNaN is considered to represent
missing data, so hypot (qNaN, Inf) is Inf but hypot (sNaN, Inf) should be
qNaN plus exception. Implementing this for hypot, fmin, fmax or complex
functions would be a new feature rather than a simple bug fix, and I don't
think you should add any tests for those functions, or comments about such
tests being missing, unless you implement that new sNaN feature at the
same time.
> Now for the policy question: How to proceed in this case? Commit the
My practice is to keep the testsuite clean on at least x86 and x86_64, by
conditioning any new tests that fail on those architectures because of
known bugs with a #if condition with a comment referencing the bug number
(there are a few existing such comments in libm-test.inc). Other
architecture maintainers may then fix the bugs for their architecture or
add such conditionals in additional cases, depending on how difficult a
fix is.
--
Joseph S. Myers
joseph@codesourcery.com
prev parent reply other threads:[~2013-04-03 15:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-03 15:30 Thomas Schwinge
2013-04-03 15:41 ` Joseph S. Myers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.1304031536570.580@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=libc-ports@sourceware.org \
--cc=thomas@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).