From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16880 invoked by alias); 29 Apr 2013 13:34:48 -0000 Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org Received: (qmail 16859 invoked by uid 89); 29 Apr 2013 13:34:47 -0000 X-Spam-SWARE-Status: No, score=-4.8 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL autolearn=ham version=3.3.1 X-Spam-User: qpsmtpd, 2 recipients Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Mon, 29 Apr 2013 13:34:47 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1UWoE9-00055E-Sd from joseph_myers@mentor.com ; Mon, 29 Apr 2013 06:34:45 -0700 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Mon, 29 Apr 2013 06:34:45 -0700 Received: from digraph.polyomino.org.uk (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.2.247.3; Mon, 29 Apr 2013 14:34:43 +0100 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.76) (envelope-from ) id 1UWoE6-00034q-AA; Mon, 29 Apr 2013 13:34:42 +0000 Date: Mon, 29 Apr 2013 13:34:00 -0000 From: "Joseph S. Myers" To: Siddhesh Poyarekar CC: , Subject: Re: [PATCH][BZ #14412] Define __sincos_finite as a fast version of sincos In-Reply-To: <20130429102739.GE1330@spoyarek.pnq.redhat.com> Message-ID: References: <20130429102739.GE1330@spoyarek.pnq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-SW-Source: 2013-04/txt/msg00106.txt.bz2 On Mon, 29 Apr 2013, Siddhesh Poyarekar wrote: > This patch brings back the assembly implementation of sincos (with > some changes) to give a fast alternative to the default sincos > implementation. This is defined as __sincos_finite and is used if the > implementing program is compiled with the -ffinite-math-only gcc flag. The changes don't seem to include accurate range reduction. Without that, I think this is inappropriate, as it will result in wildly inaccurate results for large but finite inputs. (I've stated before that all libm tests with finite inputs and outputs should be run with -ffinite-math-only - and I consider that they should pass when they pass without that option, and should not need different ulps for the different ways of running them.) -- Joseph S. Myers joseph@codesourcery.com