From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7294 invoked by alias); 4 May 2013 13:13:14 -0000 Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org Received: (qmail 7282 invoked by uid 89); 4 May 2013 13:13:13 -0000 X-Spam-SWARE-Status: No, score=-4.7 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,TW_CP,TW_QE autolearn=ham version=3.3.1 Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Sat, 04 May 2013 13:13:12 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1UYcH0-00030z-6O from joseph_myers@mentor.com ; Sat, 04 May 2013 06:13:10 -0700 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Sat, 4 May 2013 06:13:09 -0700 Received: from digraph.polyomino.org.uk (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.2.247.3; Sat, 4 May 2013 14:13:08 +0100 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.76) (envelope-from ) id 1UYcGx-0000Wj-Cg; Sat, 04 May 2013 13:13:07 +0000 Date: Sat, 04 May 2013 13:13:00 -0000 From: "Joseph S. Myers" To: Will Newton CC: , Patch Tracking Subject: Re: [PATCH, v6] ARM: Add Cortex-A15 optimized NEON and VFP memcpy routines, with IFUNC. In-Reply-To: Message-ID: References: <518171B2.5020504@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-SW-Source: 2013-05/txt/msg00029.txt.bz2 On Fri, 3 May 2013, Will Newton wrote: > On 3 May 2013 21:18, Joseph S. Myers wrote: > > Hi Joseph, > > >> This was tested on armv7l-unknown-linux-gnueabihf. One new testsuite > > > > I think string functions also need big-endian testing (which should be > > possible with userspace QEMU - you should be able to run the string tests > > that way, though not the whole testsuite). If such testing passes, this > > version is OK (though as Roland notes there's scope for further > > optimization in the __ARM_NEON__ case). > > I have tested the same code using a big-endian qemu with the > cortex-strings tests which are taken from glibc: > > http://bazaar.launchpad.net/~linaro-toolchain-dev/cortex-strings/trunk/view/head:/tests/test-memcpy.c > > I haven't built glibc big-endian yet, but I can do that if you think > it would be valuable. Yes, I believe this should be tested with the current glibc string tests for a big-endian build of glibc. -- Joseph S. Myers joseph@codesourcery.com