From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23930 invoked by alias); 17 Jun 2013 21:40:59 -0000 Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org Received: (qmail 23919 invoked by uid 89); 17 Jun 2013 21:40:59 -0000 X-Spam-SWARE-Status: No, score=-4.7 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL autolearn=ham version=3.3.1 Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Mon, 17 Jun 2013 21:40:58 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1UohAX-0006HU-AN from joseph_myers@mentor.com ; Mon, 17 Jun 2013 14:40:57 -0700 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Mon, 17 Jun 2013 14:40:56 -0700 Received: from digraph.polyomino.org.uk (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.2.247.3; Mon, 17 Jun 2013 22:40:55 +0100 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.76) (envelope-from ) id 1UohAT-00059R-TH; Mon, 17 Jun 2013 21:40:53 +0000 Date: Mon, 17 Jun 2013 21:40:00 -0000 From: "Joseph S. Myers" To: Roland McGrath CC: Subject: Re: Dynamic VFP support and math/test-fpucw In-Reply-To: <20130617194154.2287E2C095@topped-with-meat.com> Message-ID: References: <20130617194154.2287E2C095@topped-with-meat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-SW-Source: 2013-06/txt/msg00027.txt.bz2 On Mon, 17 Jun 2013, Roland McGrath wrote: > You could override the test with a sysdeps/arm/test-fpucw.c. > You could override the installed fpu_control.h with a > sysdeps/arm/include/fpu_control.h that tests NOT_IN_libc or something. The trouble is, those options seem rather fragile as well. Maybe the least bad is overriding the test with a file that just defines e.g. _LIBC_TEST and includes the main test-fpucw.c (with fpu_control.h then checking _LIBC_TEST). The difficulty with the second is that dynamic VFP detection is used in both libc and libm, so NOT_IN_libc isn't sufficient on its own. Really I suppose what's wanted, in the absence of not defining _LIBC for tests, would be a macro such as IN_tests that gets automatically defined for testcase code; then at least fpu_control.h could test that after _LIBC (if it's only tested conditional on _LIBC, namespace issues wouldn't matter for IN_tests because no user application should ever define _LIBC). -- Joseph S. Myers joseph@codesourcery.com