From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29292 invoked by alias); 18 Jun 2013 22:20:31 -0000 Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org Received: (qmail 29283 invoked by uid 89); 18 Jun 2013 22:20:30 -0000 X-Spam-SWARE-Status: No, score=-4.7 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,TW_CP autolearn=ham version=3.3.1 Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 18 Jun 2013 22:20:29 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1Up4GI-0005by-Hj from joseph_myers@mentor.com ; Tue, 18 Jun 2013 15:20:26 -0700 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Tue, 18 Jun 2013 15:20:26 -0700 Received: from digraph.polyomino.org.uk (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.2.247.3; Tue, 18 Jun 2013 23:20:24 +0100 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.76) (envelope-from ) id 1Up4G9-00020y-Um; Tue, 18 Jun 2013 22:20:18 +0000 Date: Tue, 18 Jun 2013 22:20:00 -0000 From: "Joseph S. Myers" To: Roland McGrath CC: Subject: Re: [PATCH roland/arm-memcpy] ARM: Make armv7 memcpy implementations SFI-friendly In-Reply-To: <20130618220149.CB94E2C0E4@topped-with-meat.com> Message-ID: References: <20130618220149.CB94E2C0E4@topped-with-meat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-SW-Source: 2013-06/txt/msg00036.txt.bz2 On Tue, 18 Jun 2013, Roland McGrath wrote: > * sysdeps/arm/arm-features.h (ARM_BX_NINSNS): New macro. > * sysdeps/arm/armv7/multiarch/memcpy_impl.S: Macroize the > computed-jump dispatch sections. Use sfi_breg throughout. > [ARM_ALWAYS_BX]: Define a different version of the dispatch macros > that uses bx rather than add-to-pc, and respects ARM_BX_ALIGN_LOG2. > [!USE_NEON] (D_l, D_h): Use r10, r11 rather than r8, r9. > (tmp2): Use r8 rather than r10. This is OK with the comments referring to an assembler bug amended to give a binutils bug number (and preferably an indication of for what version it was fixed) to make it easier in future to tell whether the workaround can be removed because of a higher minimum binutils version requirement. -- Joseph S. Myers joseph@codesourcery.com