From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17545 invoked by alias); 28 Jun 2013 20:25:38 -0000 Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org Received: (qmail 17255 invoked by uid 89); 28 Jun 2013 20:25:32 -0000 X-Spam-SWARE-Status: No, score=-4.7 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL autolearn=ham version=3.3.1 Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 28 Jun 2013 20:25:32 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1UsfEY-0006wm-Io from joseph_myers@mentor.com ; Fri, 28 Jun 2013 13:25:30 -0700 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Fri, 28 Jun 2013 13:25:30 -0700 Received: from digraph.polyomino.org.uk (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.2.247.3; Fri, 28 Jun 2013 21:25:28 +0100 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.76) (envelope-from ) id 1UsfEV-0002Zu-1p; Fri, 28 Jun 2013 20:25:27 +0000 Date: Fri, 28 Jun 2013 20:25:00 -0000 From: "Joseph S. Myers" To: Andreas Schwab CC: , David Holsgrove Subject: Re: Miscellaneous ColdFire patches In-Reply-To: <87obaqgjlq.fsf@igel.home> Message-ID: References: <87obaqgjlq.fsf@igel.home> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-SW-Source: 2013-06/txt/msg00067.txt.bz2 On Fri, 28 Jun 2013, Andreas Schwab wrote: > "Joseph S. Myers" writes: > > > 2013-06-28 Joseph Myers > > > > * sysdeps/unix/sysv/linux/m68k/kernel-features.h [__mcoldfire__] > > (MMAP2_PAGE_SHIFT): Define to -1. > > kernel-features.h is the wrong place to define this (mmap64.c should > actually no longer include it). You should create a mmap64.c that > defines MMAP2_PAGE_SHIFT and then falls through to the real > implementation. Also, this is an issue for sun3 as well, so it needs to > be defined for all m68k variants. > > Finally, you need to fix sysdeps/unix/sysv/linux/mmap64.c so that it > doesn't shift by -1. > > (Looks like cris and microblaze have the same bug.) This patch (untested) creates a new file and enables the change for all m68k configurations. I've sent the fix to sysdeps/unix/sysv/linux/mmap64.c to libc-alpha and filed bug 15705 for the MicroBlaze issue (the CRIS port of glibc having been removed as bitrotten some time ago). 2013-06-28 Joseph Myers * sysdeps/unix/sysv/linux/m68k/mmap64.c: New file. diff --git a/ports/sysdeps/unix/sysv/linux/m68k/mmap64.c b/ports/sysdeps/unix/sysv/linux/m68k/mmap64.c new file mode 100644 index 0000000..8bf8987 --- /dev/null +++ b/ports/sysdeps/unix/sysv/linux/m68k/mmap64.c @@ -0,0 +1,5 @@ +/* ColdFire and Sun 3 kernels have PAGE_SHIFT set to 13 and expect + mmap2 offset to be provided in 8K pages. Determine the shift + dynamically with getpagesize. */ +#define MMAP2_PAGE_SHIFT -1 +#include -- Joseph S. Myers joseph@codesourcery.com