From: "Joseph S. Myers" <joseph@codesourcery.com>
To: Mike Frysinger <vapier@gentoo.org>
Cc: <libc-alpha@sourceware.org>, <libc-ports@sourceware.org>,
<carlos@systemhalted.org>
Subject: Re: [PATCH] [RFC] hppa: add fanotify_mark
Date: Wed, 21 Aug 2013 16:30:00 -0000 [thread overview]
Message-ID: <Pine.LNX.4.64.1308211624560.32351@digraph.polyomino.org.uk> (raw)
In-Reply-To: <1377100993-9438-1-git-send-email-vapier@gentoo.org>
On Wed, 21 Aug 2013, Mike Frysinger wrote:
> Another example of all the 64bit arches getting the definition via a
> common file, but the 32bit ones all adding it by themselves and hppa
> was missed.
How about adding an architecture-independent testcase (Linux-specific, of
course) for this function? I've no idea whether it can test any semantics
of fanotify_init / fanotify_mark, or only that calls to them link OK, but
in general when fixing bugs it's a good idea to add testcases that would
have detected them, and both functions are in my list of untested symbols
<http://sourceware.org/ml/libc-alpha/2013-07/msg00386.html>, which we need
to add test coverage for bit by bit.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2013-08-21 16:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-21 16:03 Mike Frysinger
2013-08-21 16:30 ` Joseph S. Myers [this message]
2013-08-26 3:54 ` Mike Frysinger
2013-08-28 22:26 ` [PATCH v2] " Mike Frysinger
2013-08-29 12:15 ` Joseph S. Myers
2013-08-30 0:32 ` Mike Frysinger
2013-08-30 17:49 ` Carlos O'Donell
2013-08-30 20:33 ` Joseph S. Myers
2013-08-30 20:51 ` Roland McGrath
2013-09-03 16:03 ` Carlos O'Donell
2013-09-18 22:08 ` Roland McGrath
2013-09-03 3:22 ` Mike Frysinger
2013-09-03 3:20 ` [PATCH 1/2 v3] tst-fanotify: new simple test Mike Frysinger
2013-09-03 3:22 ` [PATCH 2/2 v3] hppa: add fanotify_mark Mike Frysinger
2013-09-03 3:23 ` [PATCH 1/2 v3] tst-fanotify: new simple test Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.1308211624560.32351@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=carlos@systemhalted.org \
--cc=libc-alpha@sourceware.org \
--cc=libc-ports@sourceware.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).