From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30550 invoked by alias); 29 Aug 2013 19:26:30 -0000 Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org Received: (qmail 30541 invoked by uid 89); 29 Aug 2013 19:26:30 -0000 Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 29 Aug 2013 19:26:30 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RDNS_NONE,SPF_HELO_FAIL autolearn=no version=3.3.2 X-HELO: relay1.mentorg.com Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1VF7rN-0000MS-3x from joseph_myers@mentor.com ; Thu, 29 Aug 2013 12:26:25 -0700 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Thu, 29 Aug 2013 12:26:25 -0700 Received: from digraph.polyomino.org.uk (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.2.247.3; Thu, 29 Aug 2013 20:26:23 +0100 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.76) (envelope-from ) id 1VF7rK-0000hb-89; Thu, 29 Aug 2013 19:26:22 +0000 Date: Thu, 29 Aug 2013 19:26:00 -0000 From: "Joseph S. Myers" To: Will Newton CC: , Subject: Re: [PATCH] ARM: Fix clone code when built for Thumb. In-Reply-To: <521F9E4E.5040906@linaro.org> Message-ID: References: <521F9E4E.5040906@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-SW-Source: 2013-08/txt/msg00065.txt.bz2 On Thu, 29 Aug 2013, Will Newton wrote: > The mov lr, pc instruction will lose the Thumb bit from the return address > so use blx lr instead. > > ports/ChangeLog.arm: > > 2013-08-29 Will Newton > > * sysdeps/unix/sysv/linux/arm/clone.S (__clone): Use blx > instead of mov lr, pc. OK given a bug filed in Bugzilla and appropriate [BZ #N] notation and addition of the fixed bug number to NEWS. Since this is a regression arising from the changes to build .S files as Thumb, you should also cherry-pick the fix to 2.18 branch. -- Joseph S. Myers joseph@codesourcery.com