public inbox for libc-ports@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] ARM: Fix clone code when built for Thumb.
@ 2013-08-29 19:17 Will Newton
  2013-08-29 19:26 ` Joseph S. Myers
  0 siblings, 1 reply; 6+ messages in thread
From: Will Newton @ 2013-08-29 19:17 UTC (permalink / raw)
  To: libc-ports; +Cc: patches


The mov lr, pc instruction will lose the Thumb bit from the return address
so use blx lr instead.

ports/ChangeLog.arm:

2013-08-29  Will Newton  <will.newton@linaro.org>

	* sysdeps/unix/sysv/linux/arm/clone.S (__clone): Use blx
	instead of mov lr, pc.
---
 ports/sysdeps/unix/sysv/linux/arm/clone.S | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/ports/sysdeps/unix/sysv/linux/arm/clone.S b/ports/sysdeps/unix/sysv/linux/arm/clone.S
index ce9c2a5..6e74fa7 100644
--- a/ports/sysdeps/unix/sysv/linux/arm/clone.S
+++ b/ports/sysdeps/unix/sysv/linux/arm/clone.S
@@ -93,8 +93,8 @@ PSEUDO_END (__clone)
 	mov	lr, pc
 	bx      ip
 #else
-	mov	lr, pc
-	ldr 	pc, [sp], #8
+	ldr 	lr, [sp], #8
+	blx	lr
 #endif

 	@ and we are done, passing the return value through r0
-- 
1.8.1.4

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2013-08-30 17:35 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-08-29 19:17 [PATCH] ARM: Fix clone code when built for Thumb Will Newton
2013-08-29 19:26 ` Joseph S. Myers
2013-08-29 20:19   ` Will Newton
2013-08-29 20:56     ` Add willnewton to glibc group Joseph S. Myers
2013-08-30 10:18   ` [PATCH] ARM: Fix clone code when built for Thumb Will Newton
2013-08-30 17:35     ` Carlos O'Donell

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).