From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12282 invoked by alias); 30 Aug 2013 20:36:51 -0000 Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org Received: (qmail 12273 invoked by uid 89); 30 Aug 2013 20:36:50 -0000 Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 30 Aug 2013 20:36:50 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RDNS_NONE,SPF_HELO_FAIL autolearn=no version=3.3.2 X-HELO: relay1.mentorg.com Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1VFVQz-0003cf-RL from joseph_myers@mentor.com ; Fri, 30 Aug 2013 13:36:45 -0700 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Fri, 30 Aug 2013 13:36:46 -0700 Received: from digraph.polyomino.org.uk (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.2.247.3; Fri, 30 Aug 2013 21:36:44 +0100 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.76) (envelope-from ) id 1VFVQw-0006As-VN; Fri, 30 Aug 2013 20:36:43 +0000 Date: Fri, 30 Aug 2013 20:36:00 -0000 From: "Joseph S. Myers" To: Roland McGrath CC: Subject: Re: [PATCH roland/arm-strlen] Make armv6t2 strlen work in ARM mode too. In-Reply-To: <20130830180620.77DD12C072@topped-with-meat.com> Message-ID: References: <20130830180620.77DD12C072@topped-with-meat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-SW-Source: 2013-08/txt/msg00099.txt.bz2 On Fri, 30 Aug 2013, Roland McGrath wrote: > I tested that this has no effect (assembled code wholly unchanged) on > arm-linux-gnueabihf. I tested that the ARM-mode support actually works by > hacking in "#define NO_THUMB" at the top and verifying no failures from > 'make check subdirs=string'. > > Incidentally, assembly writers really ought to write more comments! For > example, I deduced the only plausible reason for using an explicit bne.w > and added a comment about it, but it is exactly the sort of non-obvious > subtle microoptimization that desperately needed clear comments in the > first place. > > > OK for trunk? OK. -- Joseph S. Myers joseph@codesourcery.com