From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12918 invoked by alias); 5 Sep 2013 15:48:26 -0000 Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org Received: (qmail 12905 invoked by uid 89); 5 Sep 2013 15:48:26 -0000 Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 05 Sep 2013 15:48:26 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RDNS_NONE,SPF_HELO_FAIL autolearn=no version=3.3.2 X-HELO: relay1.mentorg.com Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1VHbnC-0005R8-LW from joseph_myers@mentor.com ; Thu, 05 Sep 2013 08:48:22 -0700 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Thu, 5 Sep 2013 08:48:22 -0700 Received: from digraph.polyomino.org.uk (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.2.247.3; Thu, 5 Sep 2013 16:48:21 +0100 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.76) (envelope-from ) id 1VHbn9-0007jV-Q4; Thu, 05 Sep 2013 15:48:19 +0000 Date: Thu, 05 Sep 2013 15:48:00 -0000 From: "Joseph S. Myers" To: Dinar Temirbulatov CC: , , Maxim Kuvyrkov Subject: Re: [Patch] ARM define atomic_exchange_acq/atomic_exchange_rel to __atomic_exchange_n In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-SW-Source: 2013-09/txt/msg00045.txt.bz2 On Thu, 5 Sep 2013, Dinar Temirbulatov wrote: > Hi, > Here is updated version of change. Ok to commit? You appear to insert a '$' after '\' on one line - that can't be right. Please try to test all three cases in the code. Where you have "typeof(*mem)", there should be a space before the '('. -- Joseph S. Myers joseph@codesourcery.com