From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18837 invoked by alias); 6 Sep 2013 16:59:41 -0000 Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org Received: (qmail 18804 invoked by uid 89); 6 Sep 2013 16:59:41 -0000 Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 06 Sep 2013 16:59:41 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RDNS_NONE,SPF_HELO_FAIL autolearn=no version=3.3.2 X-HELO: relay1.mentorg.com Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1VHzNg-0002tl-Tp from joseph_myers@mentor.com ; Fri, 06 Sep 2013 09:59:36 -0700 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Fri, 6 Sep 2013 09:59:36 -0700 Received: from digraph.polyomino.org.uk (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.2.247.3; Fri, 6 Sep 2013 17:59:34 +0100 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.76) (envelope-from ) id 1VHzNd-0002eA-7m; Fri, 06 Sep 2013 16:59:33 +0000 Date: Fri, 06 Sep 2013 16:59:00 -0000 From: "Joseph S. Myers" To: Steve Ellcey CC: Subject: Re: [patch, mips] Improved memset for MIPS In-Reply-To: <1378486241.5770.327.camel@ubuntu-sellcey> Message-ID: References: <93a232b5-9d0b-4a27-bbb5-16e3ae7c4b89@BAMAIL02.ba.imgtec.org> <1378483039.5770.302.camel@ubuntu-sellcey> <1378486241.5770.327.camel@ubuntu-sellcey> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-SW-Source: 2013-09/txt/msg00061.txt.bz2 On Fri, 6 Sep 2013, Steve Ellcey wrote: > I have found that --prefix=/usr is more of a problem then a help when > building general cross compiler toolchains. Using a prefix of /usr > triggers various special case code in > ports/sysdeps/unix/sysv/linux/mips/configure to put things in lib32 and > lib64 and I don't actually want any of that so I use a prefix > of /usr/fake instead of /usr. Not using --prefix=/usr runs into ABI testsuite problems with bug 14664. > The "undefined reference to `__libc_global_ctors'" has just shown up > again in a parallel build, but it seems to go away when I rebuild. I am > still trying to understand what is going on with this. Since it seems to be about parallel builds and linkobj/libc.so, try with Brooks's patch ? (Which, if it works OK on master for a while, should probably be backported to 2.18 branch.) > > The expectation is that the glibc testsuite is the normal way to test > > patches before submission, and string function patches like this need it > > to be run for all six relevant ABI variants. > > I think some flexibility here would be better. There is no floating > point code in this routine so running all three ABI's in both hard and > soft float modes seems like overkill to me. Testing in big and little > endian modes would seem more likely to turn up problems then testing in > hard and soft float. That's why I said six rather than twelve ABI variants; floating-point variants aren't relevant here, but the other variants are. You could argue for full testing for three variants that cover all of o32, n32 and n64 and both BE and LE, plus just the string/ directory tests for the other three variants, but I think that would be the minimum. -- Joseph S. Myers joseph@codesourcery.com