* [PATCH] ARM: Allow building __sigsetjmp as Thumb.
@ 2013-10-03 10:38 Will Newton
2013-10-03 16:32 ` Joseph S. Myers
0 siblings, 1 reply; 2+ messages in thread
From: Will Newton @ 2013-10-03 10:38 UTC (permalink / raw)
To: libc-ports; +Cc: patches
Convert __sigsetjmp code to allow building as Thumb.
ports/ChangeLog.arm:
2013-09-25 Will Newton <will.newton@linaro.org>
* sysdeps/arm/setjmp.S (NO_THUMB): Remove define.
(__sigsetjmp): Use Thumb supported instructions.
---
ports/sysdeps/arm/setjmp.S | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/ports/sysdeps/arm/setjmp.S b/ports/sysdeps/arm/setjmp.S
index b38b919..fedd994 100644
--- a/ports/sysdeps/arm/setjmp.S
+++ b/ports/sysdeps/arm/setjmp.S
@@ -16,8 +16,6 @@
License along with the GNU C Library. If not, see
<http://www.gnu.org/licenses/>. */
-/* ??? Needs more rearrangement for the STM to handle thumb mode. */
-#define NO_THUMB
#include <sysdep.h>
#include <bits/setjmp.h>
#include <rtld-global-offsets.h>
@@ -35,7 +33,8 @@ ENTRY (__sigsetjmp)
sfi_breg ip, \
stmia \B!, JMP_BUF_REGLIST
#ifdef PTR_MANGLE
- PTR_MANGLE2 (a4, sp, a3)
+ mov a4, sp
+ PTR_MANGLE2 (a4, a4, a3)
str a4, [ip], #4
PTR_MANGLE2 (a4, lr, a3)
str a4, [ip], #4
--
1.8.1.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ARM: Allow building __sigsetjmp as Thumb.
2013-10-03 10:38 [PATCH] ARM: Allow building __sigsetjmp as Thumb Will Newton
@ 2013-10-03 16:32 ` Joseph S. Myers
0 siblings, 0 replies; 2+ messages in thread
From: Joseph S. Myers @ 2013-10-03 16:32 UTC (permalink / raw)
To: Will Newton; +Cc: libc-ports, patches
On Thu, 3 Oct 2013, Will Newton wrote:
> Convert __sigsetjmp code to allow building as Thumb.
>
> ports/ChangeLog.arm:
>
> 2013-09-25 Will Newton <will.newton@linaro.org>
>
> * sysdeps/arm/setjmp.S (NO_THUMB): Remove define.
> (__sigsetjmp): Use Thumb supported instructions.
OK, if you've tested with the glibc testsuite for both ARM-mode and
Thumb-mode builds.
--
Joseph S. Myers
joseph@codesourcery.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-10-03 16:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-10-03 10:38 [PATCH] ARM: Allow building __sigsetjmp as Thumb Will Newton
2013-10-03 16:32 ` Joseph S. Myers
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).