public inbox for
 help / color / mirror / Atom feed
From: "Joseph S. Myers" <>
To: Steve Ellcey <>
Cc: <>
Subject: Re: [PATCH] MIPS: Use sqrt instruction on mips32 and mips64.
Date: Thu, 03 Oct 2013 19:34:00 -0000	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Thu, 3 Oct 2013, Steve Ellcey  wrote:

> This is a fix for PR 15632.  The mips32 and mips64 glibc builds are not
> using the sqrt instruction in the sqrt libm functions.  Each of the new files
> is a single line to include mips/fpu/e_sqrt.c (or e_sqrtf.c).  I initially
> tried to create mips64/fpu but that did not work so I had to create both
> mips64/n32/fpu and mips64/n64/fpu instead.
> I did not see any sqrt tests in the glibc performance benchmarks, so I just
> ran a test of my own that did a bunch of sqrt operations and compiled it
> with -O2 -fno-builtins.  It went from 61 seconds to 17 seconds on my 74k
> board.
> I also ran the glibc testsuite with the o32, n32, and n64 ABI's to verify
> there were no regressions in the testsuite.
> Ok to checkin?

OK (with of course [BZ #15632] in the ChangeLog.mips entry, and that bug 
number added to the list of fixed bugs in the NEWS file).  It would be a 
good idea to add an architecture-independent sqrt performance test, 

Joseph S. Myers

      reply	other threads:[~2013-10-03 19:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-03 18:18 Steve Ellcey 
2013-10-03 19:34 ` Joseph S. Myers [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).