From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9905 invoked by alias); 3 Oct 2013 19:34:41 -0000 Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org Received: (qmail 9889 invoked by uid 89); 3 Oct 2013 19:34:40 -0000 Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 03 Oct 2013 19:34:40 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RDNS_NONE,SPF_HELO_FAIL autolearn=no version=3.3.2 X-HELO: relay1.mentorg.com Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1VRofU-0005IK-4s from joseph_myers@mentor.com ; Thu, 03 Oct 2013 12:34:36 -0700 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Thu, 3 Oct 2013 12:34:36 -0700 Received: from digraph.polyomino.org.uk (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.2.247.3; Thu, 3 Oct 2013 20:34:34 +0100 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.76) (envelope-from ) id 1VRofR-0001Qw-Em; Thu, 03 Oct 2013 19:34:33 +0000 Date: Thu, 03 Oct 2013 19:34:00 -0000 From: "Joseph S. Myers" To: Steve Ellcey CC: Subject: Re: [PATCH] MIPS: Use sqrt instruction on mips32 and mips64. In-Reply-To: <5846cd67-3ec4-4b51-b6e2-3d50d044cbc1@BAMAIL02.ba.imgtec.org> Message-ID: References: <5846cd67-3ec4-4b51-b6e2-3d50d044cbc1@BAMAIL02.ba.imgtec.org> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-SW-Source: 2013-10/txt/msg00006.txt.bz2 On Thu, 3 Oct 2013, Steve Ellcey wrote: > This is a fix for PR 15632. The mips32 and mips64 glibc builds are not > using the sqrt instruction in the sqrt libm functions. Each of the new files > is a single line to include mips/fpu/e_sqrt.c (or e_sqrtf.c). I initially > tried to create mips64/fpu but that did not work so I had to create both > mips64/n32/fpu and mips64/n64/fpu instead. > > I did not see any sqrt tests in the glibc performance benchmarks, so I just > ran a test of my own that did a bunch of sqrt operations and compiled it > with -O2 -fno-builtins. It went from 61 seconds to 17 seconds on my 74k > board. > > I also ran the glibc testsuite with the o32, n32, and n64 ABI's to verify > there were no regressions in the testsuite. > > Ok to checkin? OK (with of course [BZ #15632] in the ChangeLog.mips entry, and that bug number added to the list of fixed bugs in the NEWS file). It would be a good idea to add an architecture-independent sqrt performance test, though. -- Joseph S. Myers joseph@codesourcery.com