public inbox for libc-ports@sourceware.org
 help / color / mirror / Atom feed
From: "Joseph S. Myers" <joseph@codesourcery.com>
To: Chung-Lin Tang <cltang@codesourcery.com>
Cc: Chris Metcalf <cmetcalf@tilera.com>,
	"libc-ports@sourceware.org"	<libc-ports@sourceware.org>,
	Andrew Pinski <pinskia@gmail.com>
Subject: Re: struct statfs/statfs64 in linux-generic
Date: Wed, 13 Nov 2013 12:59:00 -0000	[thread overview]
Message-ID: <Pine.LNX.4.64.1311131258150.18987@digraph.polyomino.org.uk> (raw)
In-Reply-To: <5283357D.2050205@codesourcery.com>

On Wed, 13 Nov 2013, Chung-Lin Tang wrote:

> 	(struct statfs): Use __alignof__(__u64) in alignment attribute
> 	instead of 8.
> 	(struct statfs64): Likewise.

I don't like the use of __u64 here - that's a kernel type, not a glibc 
one, and glibc headers shouldn't be using it.

-- 
Joseph S. Myers
joseph@codesourcery.com

  reply	other threads:[~2013-11-13 12:59 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-04  7:18 Chung-Lin Tang
2013-11-04  8:19 ` Andrew Pinski
2013-11-05  4:23   ` Chung-Lin Tang
2013-11-07 19:55 ` Chris Metcalf
2013-11-10  8:24   ` Chung-Lin Tang
2013-11-11 17:48     ` Joseph S. Myers
2013-11-13  8:17       ` Chung-Lin Tang
2013-11-13 12:59         ` Joseph S. Myers [this message]
2013-11-14  4:34           ` Chung-Lin Tang
2013-11-14 13:36             ` Joseph S. Myers
2013-11-14 18:28             ` Chris Metcalf
2013-11-15  7:39               ` Chung-Lin Tang
2013-11-18 23:39                 ` Chris Metcalf
2013-11-19 13:50                   ` Chung-Lin Tang
2013-11-22  2:43                     ` Chris Metcalf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.1311131258150.18987@digraph.polyomino.org.uk \
    --to=joseph@codesourcery.com \
    --cc=cltang@codesourcery.com \
    --cc=cmetcalf@tilera.com \
    --cc=libc-ports@sourceware.org \
    --cc=pinskia@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).