From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14882 invoked by alias); 14 Nov 2013 13:36:58 -0000 Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org Received: (qmail 14873 invoked by uid 89); 14 Nov 2013 13:36:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,RDNS_NONE,URIBL_BLOCKED autolearn=no version=3.3.2 X-HELO: relay1.mentorg.com Received: from Unknown (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 14 Nov 2013 13:36:57 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1Vgx68-0001Xu-Lb from joseph_myers@mentor.com ; Thu, 14 Nov 2013 05:36:40 -0800 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Thu, 14 Nov 2013 05:36:40 -0800 Received: from digraph.polyomino.org.uk (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.2.247.3; Thu, 14 Nov 2013 13:36:38 +0000 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.76) (envelope-from ) id 1Vgx65-0006KI-1R; Thu, 14 Nov 2013 13:36:37 +0000 Date: Thu, 14 Nov 2013 13:36:00 -0000 From: "Joseph S. Myers" To: Chung-Lin Tang CC: Chris Metcalf , "libc-ports@sourceware.org" , Andrew Pinski Subject: Re: struct statfs/statfs64 in linux-generic In-Reply-To: <528452BE.6020904@codesourcery.com> Message-ID: References: <52774A2F.5010505@codesourcery.com> <527BF01B.9080704@tilera.com> <527F42AF.8060204@codesourcery.com> <5283357D.2050205@codesourcery.com> <528452BE.6020904@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-SW-Source: 2013-11/txt/msg00013.txt.bz2 On Thu, 14 Nov 2013, Chung-Lin Tang wrote: > On 13/11/13 8:58 PM, Joseph S. Myers wrote: > > On Wed, 13 Nov 2013, Chung-Lin Tang wrote: > > > >> (struct statfs): Use __alignof__(__u64) in alignment attribute > >> instead of 8. > >> (struct statfs64): Likewise. > > > > I don't like the use of __u64 here - that's a kernel type, not a glibc > > one, and glibc headers shouldn't be using it. > > > > Sure, how about __U64_TYPE? This seems in line with using __SWORD_TYPE > from That seems reasonable to me (though it's Chris you need to reach agreement with). -- Joseph S. Myers joseph@codesourcery.com