From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3515 invoked by alias); 18 Nov 2013 13:42:22 -0000 Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org Received: (qmail 3506 invoked by uid 89); 18 Nov 2013 13:42:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,RDNS_NONE,URIBL_BLOCKED autolearn=no version=3.3.2 X-HELO: relay1.mentorg.com Received: from Unknown (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 18 Nov 2013 13:42:20 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1ViP5Y-0003OG-Qo from joseph_myers@mentor.com for libc-ports@sourceware.org; Mon, 18 Nov 2013 05:42:04 -0800 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Mon, 18 Nov 2013 05:42:04 -0800 Received: from digraph.polyomino.org.uk (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.2.247.3; Mon, 18 Nov 2013 13:42:02 +0000 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.76) (envelope-from ) id 1ViP5V-0008AM-86; Mon, 18 Nov 2013 13:42:01 +0000 Date: Mon, 18 Nov 2013 13:45:00 -0000 From: "Joseph S. Myers" To: Andrew Stubbs CC: Subject: Re: [PATCH] PAGE_SIZE definition for MIPS XLP In-Reply-To: <528A0813.10005@codesourcery.com> Message-ID: References: <528A0813.10005@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-SW-Source: 2013-11/txt/msg00031.txt.bz2 On Mon, 18 Nov 2013, Andrew Stubbs wrote: > The attached patch makes the definition conditional, rather than removing it > completely. It's not clear to me whether the HOST_* definitions are similarly > affected, but other platforms that do not define PAGE_SIZE also choose not to > define those, so I've extended the ifndef similarly. > > I this OK to commit? Should it be solved a different way? This should be raised on libc-alpha, not libc-ports, as it's a generic issue regarding what the glibc API is for PAGE_SIZE being provided or not provided in sys/user.h. It's definitely wrong to test _MIPS_ARCH_XLP like that - glibc built for generic MIPS should work on all MIPS variants supporting all the instructions used in that glibc binary, so the fact that MIPS has variable page sizes means it's always wrong for MIPS glibc to embed a page size assumption in the binaries. The question is whether PAGE_SIZE must only be defined when it is the kernel page size, or whether it should also be defined in some cases when it's some form of ABI page size even when that differs from the kernel page size. I also see no rationale given for making any of the other macros conditional. At least MicroBlaze also has variable kernel page size but defines PAGE_SIZE in sys/user.h. -- Joseph S. Myers joseph@codesourcery.com