From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22536 invoked by alias); 19 Nov 2013 13:50:53 -0000 Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org Received: (qmail 22494 invoked by uid 89); 19 Nov 2013 13:50:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,RDNS_NONE,URIBL_BLOCKED autolearn=no version=3.3.2 X-HELO: relay1.mentorg.com Received: from Unknown (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 19 Nov 2013 13:50:51 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1VilhK-0004vo-UB from joseph_myers@mentor.com ; Tue, 19 Nov 2013 05:50:34 -0800 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Tue, 19 Nov 2013 05:50:34 -0800 Received: from digraph.polyomino.org.uk (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.2.247.3; Tue, 19 Nov 2013 13:50:32 +0000 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.76) (envelope-from ) id 1VilhH-0008DT-87; Tue, 19 Nov 2013 13:50:31 +0000 Date: Tue, 19 Nov 2013 14:57:00 -0000 From: "Joseph S. Myers" To: Andrew Pinski CC: Andrew Stubbs , "libc-ports@sourceware.org" Subject: Re: [PATCH] PAGE_SIZE definition for MIPS XLP In-Reply-To: Message-ID: References: <528A0813.10005@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-SW-Source: 2013-11/txt/msg00038.txt.bz2 On Mon, 18 Nov 2013, Andrew Pinski wrote: > I think my attached patch is better way of fixing this issue which > just deletes them rather than special casing them. Deleting (for both MIPS and MicroBlaze) would indeed be better if the API for these symbols is that they should only be defined if the kernel page size is constant. Someone still needs to look into the API for all these symbols and write a proper explanation of how they are used (outside of glibc) and what requirements apply to them. It's not clear whether it's right to remove the whole block from PAGE_SHIFT to HOST_STACK_END_ADDR, or only a subset that directly depend on the page size; that may depend on whether the other symbols are ever used in a context not also depending on PAGE_SIZE (are they only for BFD's trad-core?). Given such an explanation, we can better judge a removal patch. I don't want "this causes problems, so remove it"; I want "this is incorrect because (explanation of the interface), so removing it is correct". Note that IA64 confuses things by defining a subset of the macros, including defining NBPG to PAGE_SIZE despite that header not defining PAGE_SIZE. The patch does of course need a proper bug number from glibc Bugzilla (as I noted, either a bug needs filing for all affected architectures, or separate bugs for each architecture, in accordance with glibc practice that if fixing a bug that was user-visible in a release then you also file it in Bugzilla to make searches of fixed bugs more useful) and the path in the ChangeLog entry given without the initial ports/, as appropriate for ChangeLog.mips. -- Joseph S. Myers joseph@codesourcery.com