From: "Joseph S. Myers" <joseph@codesourcery.com>
To: Roland McGrath <roland@hack.frob.com>
Cc: <libc-ports@sourceware.org>
Subject: Re: [PATCH roland/arm-memcpy-fix] ARM: Fix memcpy computed-jump calculations for ARM_ALWAYS_BX case.
Date: Fri, 22 Nov 2013 19:40:00 -0000 [thread overview]
Message-ID: <Pine.LNX.4.64.1311221337400.5029@digraph.polyomino.org.uk> (raw)
In-Reply-To: <20131122024219.836FC7469E@topped-with-meat.com>
On Thu, 21 Nov 2013, Roland McGrath wrote:
> I flubbed the first version (and its testing!) of this, so it worked in the
> synthetic situation on GNU/Linux as I was testing, but did not work in the
> actual Native Client situation that motivated the change. For this fix I
> tested on arm-linux-gnueabi with arm-features.h hacked to define
> ARM_BX_ALIGN_LOG2 to 4, define ARM_ALWAYS_BX and ARM_NO_INDEX_REGISTER, and
> define 'bx' as a macro for 'nop;bx' to simulate the Native Client build
> where it's defined as a macro that expands to two instructions. The last
> hack (the 'bx' macro) is what was missing in my testing of the original
> version; testing the trunk code with that hack demonstrated the bug.
>
> OK for trunk?
OK.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2013-11-22 13:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-22 13:38 Roland McGrath
2013-11-22 19:40 ` Joseph S. Myers [this message]
2013-11-25 9:14 ` Roland McGrath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.1311221337400.5029@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=libc-ports@sourceware.org \
--cc=roland@hack.frob.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).