From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17148 invoked by alias); 22 Nov 2013 13:38:13 -0000 Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org Received: (qmail 17112 invoked by uid 89); 22 Nov 2013 13:38:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,RDNS_NONE,URIBL_BLOCKED autolearn=no version=3.3.2 X-HELO: relay1.mentorg.com Received: from Unknown (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 22 Nov 2013 13:38:12 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1Vjqvj-0006GK-G2 from joseph_myers@mentor.com ; Fri, 22 Nov 2013 05:37:55 -0800 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Fri, 22 Nov 2013 05:37:55 -0800 Received: from digraph.polyomino.org.uk (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.2.247.3; Fri, 22 Nov 2013 13:37:53 +0000 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.76) (envelope-from ) id 1Vjqvf-0007bf-Oz; Fri, 22 Nov 2013 13:37:51 +0000 Date: Fri, 22 Nov 2013 19:40:00 -0000 From: "Joseph S. Myers" To: Roland McGrath CC: Subject: Re: [PATCH roland/arm-memcpy-fix] ARM: Fix memcpy computed-jump calculations for ARM_ALWAYS_BX case. In-Reply-To: <20131122024219.836FC7469E@topped-with-meat.com> Message-ID: References: <20131122024219.836FC7469E@topped-with-meat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-SW-Source: 2013-11/txt/msg00045.txt.bz2 On Thu, 21 Nov 2013, Roland McGrath wrote: > I flubbed the first version (and its testing!) of this, so it worked in the > synthetic situation on GNU/Linux as I was testing, but did not work in the > actual Native Client situation that motivated the change. For this fix I > tested on arm-linux-gnueabi with arm-features.h hacked to define > ARM_BX_ALIGN_LOG2 to 4, define ARM_ALWAYS_BX and ARM_NO_INDEX_REGISTER, and > define 'bx' as a macro for 'nop;bx' to simulate the Native Client build > where it's defined as a macro that expands to two instructions. The last > hack (the 'bx' macro) is what was missing in my testing of the original > version; testing the trunk code with that hack demonstrated the bug. > > OK for trunk? OK. -- Joseph S. Myers joseph@codesourcery.com