From: "Joseph S. Myers" <joseph@codesourcery.com>
To: Marcus Shawcroft <marcus.shawcroft@linaro.org>
Cc: <libc-ports@sourceware.org>
Subject: Re: [PATCH] [AArch64] Regenerate libm-test-ulps.
Date: Wed, 01 Jan 2014 17:58:00 -0000 [thread overview]
Message-ID: <Pine.LNX.4.64.1401011751480.27585@digraph.polyomino.org.uk> (raw)
In-Reply-To: <1388597911-30296-1-git-send-email-marcus.shawcroft@linaro.org>
On Wed, 1 Jan 2014, Marcus Shawcroft wrote:
> +Function: "sqrt_downward":
> +ildouble: 1
> +ldouble: 1
> +
> +Function: "sqrt_towardzero":
> +ildouble: 1
> +ldouble: 1
> +
> +Function: "sqrt_upward":
> +ildouble: 1
> +ldouble: 1
You shouldn't have sqrt ulps. This is long double, so different from the
issue you addressed with commit cb756c6d686242acdc942e3d4276e399a69a6f02.
I think you have a bug in your sfp-machine.h - its definition of
FP_ROUNDMODE is expecting the low bits to be the rounding mode, which
doesn't seem right for AArch64 - and need to fix that then regenerate the
ulps from scratch again. (That bug would also be user-visible in past
releases, so should have a bug filed in Bugzilla when fixing it, as
usual.)
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2014-01-01 17:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-01 17:39 Marcus Shawcroft
2014-01-01 17:58 ` Joseph S. Myers [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-01-29 14:47 [PATCH, AArch64] " Marcus Shawcroft
2013-07-05 8:55 [PATCH] [AArch64] " Marcus Shawcroft
2012-12-07 13:01 [PATCH] AArch64 regenerate libm-test-ulps Marcus Shawcroft
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.1401011751480.27585@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=libc-ports@sourceware.org \
--cc=marcus.shawcroft@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).