From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9287 invoked by alias); 10 Jan 2014 21:54:51 -0000 Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org Received: (qmail 9268 invoked by uid 89); 10 Jan 2014 21:54:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 10 Jan 2014 21:54:48 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1W1k2N-0004FG-IE from joseph_myers@mentor.com ; Fri, 10 Jan 2014 13:54:43 -0800 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Fri, 10 Jan 2014 13:54:43 -0800 Received: from digraph.polyomino.org.uk (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.2.247.3; Fri, 10 Jan 2014 21:54:40 +0000 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.76) (envelope-from ) id 1W1k2J-0003dL-Qw; Fri, 10 Jan 2014 21:54:39 +0000 Date: Fri, 10 Jan 2014 21:54:00 -0000 From: "Joseph S. Myers" To: Roland McGrath CC: , "GNU C. Library" Subject: Re: [PATCH roland/arm-mcount] ARM: Disable compat mcount code when unneeded. In-Reply-To: <20140110213420.A949574419@topped-with-meat.com> Message-ID: References: <20130827173014.D264D2C097@topped-with-meat.com> <20130829232658.5B2002C072@topped-with-meat.com> <20140110213420.A949574419@topped-with-meat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-SW-Source: 2014-01/txt/msg00032.txt.bz2 On Fri, 10 Jan 2014, Roland McGrath wrote: > I've done an arm-linux-gnueabi build and verified that arm-mcount.o{,s} > have no differences except for the addition of the __mcount_arm_compat > symbol, and that 'make check-abi' still passes. > > I've done an arm-linux-gnueabihf build and verified that arm-mcount.o has > no differences except the removal of the _mcount code and the mcount alias, > and that arm-mcount.os has no differences except in its symbol table, and > that 'make check-abi' still passes. That is, the one user-visible change > here is that the symbols _mcount and mcount are no longer available at link > time (either static or dynamic) for arm-linux-gnueabihf. Does that merit a > NEWS mention? I don't think a NEWS mention is needed; making symbols no longer available at link time should get a mention if users might have used them directly, but I don't see a need where the symbols couldn't sensibly have been called directly from user C code. The change is OK with me for 2.19, since there's still another ARM issue pending before doing ARM release testing for 2.19. -- Joseph S. Myers joseph@codesourcery.com