From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18409 invoked by alias); 28 Jan 2014 21:35:13 -0000 Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org Received: (qmail 18382 invoked by uid 89); 28 Jan 2014 21:35:09 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 28 Jan 2014 21:35:08 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1W8GJE-0003RW-US from joseph_myers@mentor.com ; Tue, 28 Jan 2014 13:35:05 -0800 Received: from SVR-IES-FEM-02.mgc.mentorg.com ([137.202.0.106]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Tue, 28 Jan 2014 13:35:04 -0800 Received: from digraph.polyomino.org.uk (137.202.0.76) by SVR-IES-FEM-02.mgc.mentorg.com (137.202.0.106) with Microsoft SMTP Server id 14.2.247.3; Tue, 28 Jan 2014 21:35:03 +0000 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.76) (envelope-from ) id 1W8GJC-000175-5g; Tue, 28 Jan 2014 21:35:02 +0000 Date: Tue, 28 Jan 2014 21:35:00 -0000 From: "Joseph S. Myers" To: Will Newton CC: , Subject: Re: [PATCH] ARM: Add SystemTap probes to longjmp and setjmp. In-Reply-To: <1390815426-10792-1-git-send-email-will.newton@linaro.org> Message-ID: References: <1390815426-10792-1-git-send-email-will.newton@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-SW-Source: 2014-01/txt/msg00066.txt.bz2 On Mon, 27 Jan 2014, Will Newton wrote: > @@ -50,6 +48,11 @@ ENTRY (__longjmp) > ldr sp, [ip], #4 > ldr lr, [ip], #4 > #endif > + /* longjmp probe expects longjmp first argument (4@r0), second > + argument (-4@r1), and target address (4@r14), respectively. */ > + LIBC_PROBE (longjmp, 3, 4@r0, -4@r1, 4@r14) The discussion on libc-alpha said this probe should be before unwinding; shouldn't that mean before sp and lr are restored, so that at probe time it's still possible to unwind through the caller of longjmp? -- Joseph S. Myers joseph@codesourcery.com