From: "Joseph S. Myers" <joseph@codesourcery.com>
To: David Holsgrove <david.holsgrove@xilinx.com>
Cc: <libc-ports@sourceware.org>
Subject: Re: [PATCH, COMMITTED] [MicroBlaze BZ #15705] Define MMAP2_PAGE_SHIFT
Date: Wed, 05 Feb 2014 16:50:00 -0000 [thread overview]
Message-ID: <Pine.LNX.4.64.1402051648300.7511@digraph.polyomino.org.uk> (raw)
In-Reply-To: <e3b9efe0-f5a8-422a-87bb-a89b6ff9b4c2@TX2EHSMHS011.ehs.local>
On Wed, 5 Feb 2014, David Holsgrove wrote:
> +/* Microblaze kernel has PAGE_SHIFT set to 12.
> + Determine the shift dynamically with getpagesize. */
The comment "has PAGE_SHIFT set to 12" seems inaccurate. The reason you
need to determine it dynamically is that the kernel
(arch/microblaze/include/asm/page.h) may define it to any of 12, 14 or 16,
depending on configuration options. If it were constant, you could just
use a suitable constant value here instead of -1.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2014-02-05 16:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-05 7:48 David Holsgrove
2014-02-05 16:50 ` Joseph S. Myers [this message]
2014-02-06 1:34 ` David Holsgrove
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.1402051648300.7511@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=david.holsgrove@xilinx.com \
--cc=libc-ports@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).