From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29638 invoked by alias); 10 Feb 2014 22:28:37 -0000 Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org Received: (qmail 29627 invoked by uid 89); 10 Feb 2014 22:28:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 10 Feb 2014 22:28:35 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1WCzL6-00067f-0Z from joseph_myers@mentor.com for libc-ports@sourceware.org; Mon, 10 Feb 2014 14:28:32 -0800 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Mon, 10 Feb 2014 14:28:31 -0800 Received: from digraph.polyomino.org.uk (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.2.247.3; Mon, 10 Feb 2014 22:28:29 +0000 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.76) (envelope-from ) id 1WCzL2-0007Bp-Hn for libc-ports@sourceware.org; Mon, 10 Feb 2014 22:28:28 +0000 Date: Mon, 10 Feb 2014 22:28:00 -0000 From: "Joseph S. Myers" To: Subject: Move shared umount.c from hppa to mips Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-SW-Source: 2014-02/txt/msg00021.txt.bz2 This patch prepares for moving mips from ports to libc by reversing the #include ordering between mips and hppa. Reversing #include ordering for umount.c is the conservative change in preparation for moving the mips port. In fact, it appears there are several redundant umount.c files all implementing umount in terms of the umount2 syscall; I've filed bug 16552 for eliminating that redundancy properly. Tested that disassembly of shared libraries for mips (o32, n32, n64) is the same before and after this patch and committed. ports/ChangeLog.hppa: 2014-02-10 Joseph Myers * sysdeps/unix/sysv/linux/hppa/umount.c: Move to sysdeps/unix/sysv/linux/mips/mips64/umount.c and #include that file. ports/ChangeLog.mips: 2014-02-10 Joseph Myers * sysdeps/unix/sysv/linux/mips/mips64/umount.c: Move from sysdeps/unix/sysv/linux/hppa/umount.c instead of #include of that file. diff --git a/ports/sysdeps/unix/sysv/linux/hppa/umount.c b/ports/sysdeps/unix/sysv/linux/hppa/umount.c index b8e499d..208fbec 100644 --- a/ports/sysdeps/unix/sysv/linux/hppa/umount.c +++ b/ports/sysdeps/unix/sysv/linux/hppa/umount.c @@ -1,30 +1 @@ -/* Copyright (C) 2000-2014 Free Software Foundation, Inc. - This file is part of the GNU C Library. - Contributed by David Huggins-Daines , 2000. - - The GNU C Library is free software; you can redistribute it and/or - modify it under the terms of the GNU Lesser General Public - License as published by the Free Software Foundation; either - version 2.1 of the License, or (at your option) any later version. - - The GNU C Library is distributed in the hope that it will be useful, - but WITHOUT ANY WARRANTY; without even the implied warranty of - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU - Lesser General Public License for more details. - - You should have received a copy of the GNU Lesser General Public - License along with the GNU C Library. If not, see - . */ - -/* Since we don't have an oldumount system call, do what the kernel - does down here. */ - -extern long int __umount2 (const char *name, int flags); - -long int -__umount (const char *name) -{ - return __umount2 (name, 0); -} - -weak_alias (__umount, umount); +#include diff --git a/ports/sysdeps/unix/sysv/linux/mips/mips64/umount.c b/ports/sysdeps/unix/sysv/linux/mips/mips64/umount.c index 9a91ba5..b8e499d 100644 --- a/ports/sysdeps/unix/sysv/linux/mips/mips64/umount.c +++ b/ports/sysdeps/unix/sysv/linux/mips/mips64/umount.c @@ -1 +1,30 @@ -#include +/* Copyright (C) 2000-2014 Free Software Foundation, Inc. + This file is part of the GNU C Library. + Contributed by David Huggins-Daines , 2000. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library. If not, see + . */ + +/* Since we don't have an oldumount system call, do what the kernel + does down here. */ + +extern long int __umount2 (const char *name, int flags); + +long int +__umount (const char *name) +{ + return __umount2 (name, 0); +} + +weak_alias (__umount, umount); -- Joseph S. Myers joseph@codesourcery.com