public inbox for libc-ports@sourceware.org
 help / color / mirror / Atom feed
From: "Joseph S. Myers" <joseph@codesourcery.com>
To: Maxim Kuvyrkov <maxim.kuvyrkov@linaro.org>
Cc: Will Newton <will.newton@linaro.org>, <bniebuhr@efjohnson.com>,
	<uclibc@uclibc.org>,
	"libc-ports@sourceware.org" <libc-ports@sourceware.org>,
	libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH] Fix __lll_timedlock_wait busy-wait issue
Date: Thu, 27 Mar 2014 22:19:00 -0000	[thread overview]
Message-ID: <Pine.LNX.4.64.1403272216561.25264@digraph.polyomino.org.uk> (raw)
In-Reply-To: <AAA7B2C5-5A95-4B74-B792-E99B2C27643E@linaro.org>

On Fri, 28 Mar 2014, Maxim Kuvyrkov wrote:

> On Mar 28, 2014, at 11:01 AM, Joseph S. Myers <joseph@codesourcery.com> wrote:
> 
> > I don't know how this might relate to 
> > <https://sourceware.org/bugzilla/show_bug.cgi?id=15119> (see 
> > <https://sourceware.org/ml/libc-ports/2013-01/msg00084.html> and 
> > <https://sourceware.org/ml/libc-ports/2013-02/msg00021.html> and the rest 
> > of that thread).  But my preference for how to address this is definitely 
> > to move to unifying lowlevellock.[ch] files across as many architectures 
> > as possible - which requires someone to understand the differences and 
> > produce a careful analysis that shows what the best form for generic files 
> > is and what cases actually require architecture-specific files to override 
> > those generic files (preferably overriding only the bits that need 
> > overriding).
> 
> Yeap, it's the same issue in the PR and same solution as in this thread.  
> Unfortunately, the previous discussion veered off towards sparc away 
> from ARM and got forgotten.

The present thread is specifically discussing lowlevellock.c, but Carlos 
suggested in the previous discussion that the real issue was in 
__lll_timedlock in lowlevellock.h.  I think both files need unification 
across architectures.

-- 
Joseph S. Myers
joseph@codesourcery.com

  reply	other threads:[~2014-03-27 22:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1395409800-4457-1-git-send-email-bniebuhr@efjohnson.com>
2014-03-27 20:31 ` Maxim Kuvyrkov
2014-03-27 20:54   ` Will Newton
2014-03-27 22:01     ` Joseph S. Myers
2014-03-27 22:14       ` Maxim Kuvyrkov
2014-03-27 22:19         ` Joseph S. Myers [this message]
2014-03-28 18:25       ` Torvald Riegel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.1403272216561.25264@digraph.polyomino.org.uk \
    --to=joseph@codesourcery.com \
    --cc=bniebuhr@efjohnson.com \
    --cc=libc-alpha@sourceware.org \
    --cc=libc-ports@sourceware.org \
    --cc=maxim.kuvyrkov@linaro.org \
    --cc=uclibc@uclibc.org \
    --cc=will.newton@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).