From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8153 invoked by alias); 24 Jan 2013 12:47:42 -0000 Received: (qmail 8145 invoked by uid 22791); 24 Jan 2013 12:47:42 -0000 X-SWARE-Spam-Status: No, hits=-4.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 24 Jan 2013 12:47:35 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1TyMDP-0002wX-92 from Maciej_Rozycki@mentor.com for libc-ports@sourceware.org; Thu, 24 Jan 2013 04:47:35 -0800 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Thu, 24 Jan 2013 04:47:35 -0800 Received: from [172.30.4.21] (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.1.289.1; Thu, 24 Jan 2013 12:47:33 +0000 Date: Thu, 24 Jan 2013 12:47:00 -0000 From: "Maciej W. Rozycki" To: "Joseph S. Myers" CC: Subject: Re: [PATCH][BZ #15054] MIPS: Fix syscall wrappers for syscall restart support In-Reply-To: Message-ID: References: User-Agent: Alpine 1.10 (DEB 962 2008-03-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org X-SW-Source: 2013-01/txt/msg00048.txt.bz2 On Wed, 23 Jan 2013, Joseph S. Myers wrote: > > +#ifdef __mips_micromips > > +#define MOVE32 "move32" > > +#else > > +#define MOVE32 "move" > > +#endif > > Indent preprocessor directives inside #if, so "# define", here and in the > other instances of this code in the patch. > > > + register long __s0 asm("$16") __attribute__((unused)) = number; \ > > Space between __attribute__ and ((unused)), everywhere this construct > appears in this patch. Oops, sorry about this oversight -- presumably there needs to be a space between asm and () as well, right? It looks like we don't respect this requirement at all right now throughout the files concerned. > OK with those whitespace fixes; remember to update the list of fixed bugs > in the NEWS file (a single list is used for both libc and ports bugs) as > part of your commit of the fix, and to close the bug as fixed afterwards. I'll do, thanks for the tips. Maciej