From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31166 invoked by alias); 21 May 2013 20:03:51 -0000 Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org Received: (qmail 31156 invoked by uid 89); 21 May 2013 20:03:51 -0000 X-Spam-SWARE-Status: No, score=-4.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL autolearn=ham version=3.3.1 Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 21 May 2013 20:03:50 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1Uesmh-0004Df-PH from Maciej_Rozycki@mentor.com for libc-ports@sourceware.org; Tue, 21 May 2013 13:03:47 -0700 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Tue, 21 May 2013 13:03:47 -0700 Received: from [172.30.64.76] (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.2.247.3; Tue, 21 May 2013 21:03:46 +0100 Date: Tue, 21 May 2013 20:03:00 -0000 From: "Maciej W. Rozycki" To: "Joseph S. Myers" CC: Subject: Re: Fix MIPS n32 cancellation in static libc (bug 15506) In-Reply-To: Message-ID: References: User-Agent: Alpine 1.10 (DEB 962 2008-03-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-SW-Source: 2013-05/txt/msg00093.txt.bz2 On Tue, 21 May 2013, Joseph S. Myers wrote: > Bug 15506 is missing cancellation wrappers in static MIPS n32 glibc > when GCC is configured with --with-mips-plt, as referred to by > but with > apparently no bug report filed in Bugzilla at that time. > > This patch fixes this by creating a non-PIC version of the n32/n64 > sysdep-cancel.h PSEUDO macro. Tested with NPTL tests for n32 (GCC > --with-mips-plt), where it fixes failures of tst-cancel21-static and > tst-cancel-wrappers. Maciej, does this patch seem sane to you? Functionally it looks about right to me. Eventually I think it would be good to merge the two PSEUDO macro variants along the lines of how ports/sysdeps/unix/sysv/linux/mips/nptl/sysdep-cancel.h does it. Also formatting of PSEUDO is weird in both files (a preexisting problem). Thanks for fixing this issue. Maciej