public inbox for libc-ports@sourceware.org
 help / color / mirror / Atom feed
From: "Maciej W. Rozycki" <macro@codesourcery.com>
To: "Joseph S. Myers" <joseph@codesourcery.com>
Cc: <libc-ports@sourceware.org>, <libc-alpha@sourceware.org>,
	Thomas Schwinge	<thomas@codesourcery.com>,
	Doug Gilmore <Doug.Gilmore@imgtec.com>
Subject: Re: [PATCH v3] MIPS: IEEE 754-2008 NaN encoding support
Date: Wed, 18 Sep 2013 20:48:00 -0000	[thread overview]
Message-ID: <alpine.DEB.1.10.1309180015380.4379@tp.orcam.me.uk> (raw)
In-Reply-To: <Pine.LNX.4.64.1309161524580.22677@digraph.polyomino.org.uk>

On Mon, 16 Sep 2013, Joseph S. Myers wrote:

> >  Thanks.  Here's a small update including a change made by Thomas that I 
> > missed in the original submission (sorry):
> > 
> > 	* sysdeps/mips/math_private.h [__mips_nan2008]
> > 	(HIGH_ORDER_BIT_IS_SET_FOR_SNAN): Don't define.
> > 	* sysdeps/mips/bits/nan.h [__mips_nan2008] (NAN, __qnan_bytes):
> > 	Define appropriately.
> > 
> > I hope that these changes are OK.  No regressions in o32/n64/n32 testing.
> > 
> >  OK for this version?
> 
> OK, though the bits/nan.h change in the case for pre-3.3 GCC is redundant 
> since no such GCC will define __mips_nan2008.

 I've been pondering about that part, in particular whether as an 
alternative we'd need a #error directive to catch the unsupported 
__mips_nan2008/pre-3.3-GCC case.  Eventually I decided to propose it as 
is, as it is technically correct, however without any explicit mention of 
it so as not to suggest anything.  Now that you've questioned it by 
yourself, I have replaced that hunk altogether with a informational note:

/* No 2008-NaN mode support in any GCC version before 4.9.  */

 I have applied this change now, with this adjustment made.  Thanks for 
your review.

  Maciej

      reply	other threads:[~2013-09-18 20:48 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-22 23:53 [RFC][PATCH] " Maciej W. Rozycki
2013-08-23  0:58 ` Rich Felker
2013-08-23  1:41   ` Maciej W. Rozycki
2013-08-23  1:57     ` Rich Felker
2013-08-23  3:11       ` pinskia
2013-08-23  3:38         ` Rich Felker
2013-08-23  4:08           ` pinskia
2013-08-23  4:12             ` Rich Felker
2013-08-23  4:10     ` Rich Felker
2013-08-23  3:46 ` Rich Felker
2013-08-23 10:53   ` Maciej W. Rozycki
2013-08-23 15:26 ` Joseph S. Myers
2013-09-05 22:47   ` [RFC][PATCH v2] " Maciej W. Rozycki
2013-09-06 16:24     ` Joseph S. Myers
2013-09-10  9:36       ` Maciej W. Rozycki
2013-09-10 23:24         ` Joseph S. Myers
2013-09-16 15:14           ` [PATCH v3] " Maciej W. Rozycki
2013-09-16 15:26             ` Joseph S. Myers
2013-09-18 20:48               ` Maciej W. Rozycki [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.1.10.1309180015380.4379@tp.orcam.me.uk \
    --to=macro@codesourcery.com \
    --cc=Doug.Gilmore@imgtec.com \
    --cc=joseph@codesourcery.com \
    --cc=libc-alpha@sourceware.org \
    --cc=libc-ports@sourceware.org \
    --cc=thomas@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).