From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20846 invoked by alias); 18 Sep 2013 20:48:22 -0000 Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org Received: (qmail 20807 invoked by uid 89); 18 Sep 2013 20:48:22 -0000 Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 18 Sep 2013 20:48:22 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.0 required=5.0 tests=AWL,BAYES_50,KHOP_THREADED,RDNS_NONE,SPF_HELO_FAIL autolearn=no version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: relay1.mentorg.com Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1VMOfZ-0004rp-Vs from Maciej_Rozycki@mentor.com ; Wed, 18 Sep 2013 13:48:18 -0700 Received: from SVR-IES-FEM-02.mgc.mentorg.com ([137.202.0.106]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Wed, 18 Sep 2013 13:48:17 -0700 Received: from [172.30.64.65] (137.202.0.76) by SVR-IES-FEM-02.mgc.mentorg.com (137.202.0.106) with Microsoft SMTP Server id 14.2.247.3; Wed, 18 Sep 2013 21:48:16 +0100 Date: Wed, 18 Sep 2013 20:48:00 -0000 From: "Maciej W. Rozycki" To: "Joseph S. Myers" CC: , , Thomas Schwinge , Doug Gilmore Subject: Re: [PATCH v3] MIPS: IEEE 754-2008 NaN encoding support In-Reply-To: Message-ID: References: User-Agent: Alpine 1.10 (DEB 962 2008-03-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-SW-Source: 2013-09/txt/msg00103.txt.bz2 On Mon, 16 Sep 2013, Joseph S. Myers wrote: > > Thanks. Here's a small update including a change made by Thomas that I > > missed in the original submission (sorry): > > > > * sysdeps/mips/math_private.h [__mips_nan2008] > > (HIGH_ORDER_BIT_IS_SET_FOR_SNAN): Don't define. > > * sysdeps/mips/bits/nan.h [__mips_nan2008] (NAN, __qnan_bytes): > > Define appropriately. > > > > I hope that these changes are OK. No regressions in o32/n64/n32 testing. > > > > OK for this version? > > OK, though the bits/nan.h change in the case for pre-3.3 GCC is redundant > since no such GCC will define __mips_nan2008. I've been pondering about that part, in particular whether as an alternative we'd need a #error directive to catch the unsupported __mips_nan2008/pre-3.3-GCC case. Eventually I decided to propose it as is, as it is technically correct, however without any explicit mention of it so as not to suggest anything. Now that you've questioned it by yourself, I have replaced that hunk altogether with a informational note: /* No 2008-NaN mode support in any GCC version before 4.9. */ I have applied this change now, with this adjustment made. Thanks for your review. Maciej