From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31227 invoked by alias); 21 Sep 2013 18:47:37 -0000 Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org Received: (qmail 31217 invoked by uid 89); 21 Sep 2013 18:47:36 -0000 Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 21 Sep 2013 18:47:36 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.4 required=5.0 tests=AWL,BAYES_40,RDNS_NONE,SPF_HELO_FAIL autolearn=no version=3.3.2 X-HELO: relay1.mentorg.com Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1VNSDG-0006Bq-3I from Maciej_Rozycki@mentor.com ; Sat, 21 Sep 2013 11:47:26 -0700 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Sat, 21 Sep 2013 11:47:25 -0700 Received: from [172.30.64.47] (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.2.247.3; Sat, 21 Sep 2013 19:47:23 +0100 Date: Sat, 21 Sep 2013 18:47:00 -0000 From: "Maciej W. Rozycki" To: Steve Ellcey , Carlos O'Donell CC: "Joseph S. Myers" , , "Maciej W. Rozycki" Subject: Re: [PATCH] Speed up libm on MIPS In-Reply-To: <523C80A9.6070700@redhat.com> Message-ID: References: <1379631395.5770.445.camel@ubuntu-sellcey> <523BC1B8.4040102@redhat.com> <1379695885.5770.463.camel@ubuntu-sellcey> <523C80A9.6070700@redhat.com> User-Agent: Alpine 1.10 (DEB 962 2008-03-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-SW-Source: 2013-09/txt/msg00120.txt.bz2 On Fri, 20 Sep 2013, Carlos O'Donell wrote: > > 2013-09-19 Steve Ellcey > > > > * sysdeps/mips/fpu_control.h (_FPU_RC_MASK): New. > > * sysdeps/mips/fpu/fegetround.c (fegetround): Use _FPU_RC_MASK. > > * sysdeps/mips/fpu/fesetround.c (fesetround): Use _FPU_RC_MASK. > > Looks good to me. You should just check this in as an obvious cleanup. Except with a small formatting fix to comply with the GNU Coding Standards: On Fri, 20 Sep 2013, Steve Ellcey wrote: > diff --git a/ports/sysdeps/mips/fpu_control.h b/ports/sysdeps/mips/fpu_control.h > index 4046962..f26b736 100644 > --- a/ports/sysdeps/mips/fpu_control.h > +++ b/ports/sysdeps/mips/fpu_control.h > @@ -90,6 +90,8 @@ extern fpu_control_t __fpu_control; > #define _FPU_RC_ZERO 0x1 > #define _FPU_RC_UP 0x2 > #define _FPU_RC_DOWN 0x3 > +/* mask for rounding control */ > +#define _FPU_RC_MASK 0x3 -- the comment is expected to say: /* Mask for rounding control. */ i.e. start with a capital letter, end with a full stop and put two spaces exactly after the full stop. According to the GNU Coding Standards all comments have to be proper sentences with two spaces following every punctuation mark ending a sentence. For further details please refer to: http://www.gnu.org/prep/standards/standards.html#Comments Maciej