public inbox for libc-ports@sourceware.org
 help / color / mirror / Atom feed
From: "Maciej W. Rozycki" <macro@codesourcery.com>
To: Andreas Schwab <schwab@suse.de>
Cc: Andrew Stubbs <ams@codesourcery.com>, <libc-ports@sourceware.org>
Subject: Re: [PATCH] PAGE_SIZE definition for MIPS XLP
Date: Tue, 19 Nov 2013 20:56:00 -0000	[thread overview]
Message-ID: <alpine.DEB.1.10.1311192009010.21686@tp.orcam.me.uk> (raw)
In-Reply-To: <mvm38mtlvpj.fsf@hawking.suse.de>

On Mon, 18 Nov 2013, Andreas Schwab wrote:

> > The attached patch makes the definition conditional, rather than removing
> > it completely. It's not clear to me whether the HOST_* definitions are
> > similarly affected, but other platforms that do not define PAGE_SIZE also
> > choose not to define those, so I've extended the ifndef similarly.
> 
> These definitions are used by gdb for trad-core support.  Does MIPS
> support trad-core?

 I don't think it does, not at least on Linux where ELF has been ever used 
only (and ECOFF compatibility ABI never implemented), but as a side note 
trad-core has this:

#ifndef NBPG
# define NBPG getpagesize()
#endif

so it seems to be broken anyway for non-native cases.  I'd expect the page 
size in a core file to match that used by the kernel while the process was 
still alive, so it would have to be figured out from the core binary being 
handled somehow if at all possible; otherwise a user-supplied parameter.

  Maciej

  reply	other threads:[~2013-11-19 20:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-18 12:51 Andrew Stubbs
2013-11-18 13:42 ` Andreas Schwab
2013-11-19 20:56   ` Maciej W. Rozycki [this message]
2013-11-18 13:45 ` Joseph S. Myers
2013-11-18 18:21 ` Joseph S. Myers
2013-11-19  3:28 ` Andrew Pinski
2013-11-19 14:57   ` Joseph S. Myers
2013-11-19 20:19     ` Andrew Stubbs
2013-11-20 19:57   ` Maciej W. Rozycki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.1.10.1311192009010.21686@tp.orcam.me.uk \
    --to=macro@codesourcery.com \
    --cc=ams@codesourcery.com \
    --cc=libc-ports@sourceware.org \
    --cc=schwab@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).