From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5141 invoked by alias); 19 Nov 2013 20:19:39 -0000 Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org Received: (qmail 5132 invoked by uid 89); 19 Nov 2013 20:19:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.6 required=5.0 tests=AWL,BAYES_00,RDNS_NONE autolearn=no version=3.3.2 X-HELO: relay1.mentorg.com Received: from Unknown (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 19 Nov 2013 20:19:36 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1VirlZ-0005GI-9e from Maciej_Rozycki@mentor.com ; Tue, 19 Nov 2013 12:19:21 -0800 Received: from SVR-IES-FEM-02.mgc.mentorg.com ([137.202.0.106]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Tue, 19 Nov 2013 12:19:21 -0800 Received: from [172.30.64.178] (137.202.0.76) by SVR-IES-FEM-02.mgc.mentorg.com (137.202.0.106) with Microsoft SMTP Server id 14.2.247.3; Tue, 19 Nov 2013 20:19:19 +0000 Date: Tue, 19 Nov 2013 20:56:00 -0000 From: "Maciej W. Rozycki" To: Andreas Schwab CC: Andrew Stubbs , Subject: Re: [PATCH] PAGE_SIZE definition for MIPS XLP In-Reply-To: Message-ID: References: <528A0813.10005@codesourcery.com> User-Agent: Alpine 1.10 (DEB 962 2008-03-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-SW-Source: 2013-11/txt/msg00040.txt.bz2 On Mon, 18 Nov 2013, Andreas Schwab wrote: > > The attached patch makes the definition conditional, rather than removing > > it completely. It's not clear to me whether the HOST_* definitions are > > similarly affected, but other platforms that do not define PAGE_SIZE also > > choose not to define those, so I've extended the ifndef similarly. > > These definitions are used by gdb for trad-core support. Does MIPS > support trad-core? I don't think it does, not at least on Linux where ELF has been ever used only (and ECOFF compatibility ABI never implemented), but as a side note trad-core has this: #ifndef NBPG # define NBPG getpagesize() #endif so it seems to be broken anyway for non-native cases. I'd expect the page size in a core file to match that used by the kernel while the process was still alive, so it would have to be figured out from the core binary being handled somehow if at all possible; otherwise a user-supplied parameter. Maciej