From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5270 invoked by alias); 6 May 2012 05:55:26 -0000 Received: (qmail 5260 invoked by uid 22791); 6 May 2012 05:55:25 -0000 X-SWARE-Spam-Status: No, hits=-2.6 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from eddie.linux-mips.org (HELO cvs.linux-mips.org) (78.24.191.182) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 06 May 2012 05:55:06 +0000 Received: from localhost.localdomain ([127.0.0.1]:45691 "EHLO localhost.localdomain" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S1903609Ab2EFFzE (ORCPT ); Sun, 6 May 2012 07:55:04 +0200 Date: Sun, 06 May 2012 05:55:00 -0000 From: "Maciej W. Rozycki" To: "Joseph S. Myers" cc: libc-ports@sourceware.org Subject: Re: Avoid endian.h include in MIPS string functions In-Reply-To: Message-ID: References: User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-IsSubscribed: yes Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org X-SW-Source: 2012-05/txt/msg00015.txt.bz2 On Thu, 26 Apr 2012, Joseph S. Myers wrote: > Similar to a recent SH libc change, I've applied this patch to avoid MIPS > string .S functions including and getting errors from C source > code from that header. Hmm, is a user header and I could imagine software to rely on it even in handcoded assembly. And it used to work just fine. Are you sure the problematic stuff in or pulled by it shouldn't be wrapped into: #ifndef __ASSEMBLER__ or suchlike instead? Maciej