From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24604 invoked by alias); 29 Nov 2012 08:03:17 -0000 Received: (qmail 24590 invoked by uid 22791); 29 Nov 2012 08:03:16 -0000 X-SWARE-Spam-Status: No, hits=-3.7 required=5.0 tests=AWL,BAYES_00,FRT_OFFER2,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_NO,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RCVD_IN_HOSTKARMA_YE,TW_XB X-Spam-Check-By: sourceware.org Received: from tx2ehsobe001.messaging.microsoft.com (HELO tx2outboundpool.messaging.microsoft.com) (65.55.88.11) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 29 Nov 2012 08:03:10 +0000 Received: from mail119-tx2-R.bigfish.com (10.9.14.252) by TX2EHSOBE006.bigfish.com (10.9.40.26) with Microsoft SMTP Server id 14.1.225.23; Thu, 29 Nov 2012 08:03:09 +0000 Received: from mail119-tx2 (localhost [127.0.0.1]) by mail119-tx2-R.bigfish.com (Postfix) with ESMTP id D2E713602F9; Thu, 29 Nov 2012 08:03:09 +0000 (UTC) X-Forefront-Antispam-Report: CIP:149.199.60.83;KIP:(null);UIP:(null);IPV:NLI;H:xsj-gw1;RD:unknown-60-83.xilinx.com;EFVD:NLI X-SpamScore: -12 X-BigFish: VPS-12(zzbb2dI98dI9371Ic89bh936eI154dI542M1432I4015I1447Izz1de0h1202h1d1ah1d2ahzz177df4h17326ah8275bh8275dhz2fh95h668h839hd24hf0ah119dh1288h12a5h12a9h12bdh137ah13b6h1441h14ddh1504h1537h153bh162dh1631h906i1155h) Received-SPF: pass (mail119-tx2: domain of xilinx.com designates 149.199.60.83 as permitted sender) client-ip=149.199.60.83; envelope-from=david.holsgrove@xilinx.com; helo=xsj-gw1 ;helo=xsj-gw1 ; Received: from mail119-tx2 (localhost.localdomain [127.0.0.1]) by mail119-tx2 (MessageSwitch) id 1354176188380669_24939; Thu, 29 Nov 2012 08:03:08 +0000 (UTC) Received: from TX2EHSMHS027.bigfish.com (unknown [10.9.14.235]) by mail119-tx2.bigfish.com (Postfix) with ESMTP id 5600B4023E; Thu, 29 Nov 2012 08:03:08 +0000 (UTC) Received: from xsj-gw1 (149.199.60.83) by TX2EHSMHS027.bigfish.com (10.9.99.127) with Microsoft SMTP Server id 14.1.225.23; Thu, 29 Nov 2012 08:03:02 +0000 Received: from unknown-38-66.xilinx.com ([149.199.38.66] helo=xsj-smtp1.xilinx.com) by xsj-gw1 with esmtp (Exim 4.63) (envelope-from ) id 1Tdz5J-0006Dm-Qx; Thu, 29 Nov 2012 00:03:01 -0800 From: David Holsgrove To: Andreas Jaeger CC: "libc-alpha@sourceware.org" , "libc-ports@sourceware.org" , John Williams , "Edgar E. Iglesias" , Vinod Kathail , Tom Shui , Vidhumouli Hunsigida , Nagaraju Mekala Subject: RE: [PATCH 2/3 elf] Add MicroBlaze support to elf.h Date: Thu, 29 Nov 2012 08:03:00 -0000 References: <50B70BC6.5020502@suse.com> In-Reply-To: <50B70BC6.5020502@suse.com> Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-RCIS-Action: ALLOW Message-ID: X-OriginatorOrg: xilinx.com Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org X-SW-Source: 2012-11/txt/msg00129.txt.bz2 Hi Andreas, > -----Original Message----- > From: Andreas Jaeger [mailto:aj@suse.com] > Sent: Thursday, 29 November 2012 5:16 pm > To: David Holsgrove > Cc: libc-alpha@sourceware.org; libc-ports@sourceware.org; John Williams; = Edgar > E. Iglesias; Vinod Kathail; Tom Shui; Vidhumouli Hunsigida; Nagaraju Meka= la > Subject: Re: [PATCH 2/3 elf] Add MicroBlaze support to elf.h >=20 > On 11/29/2012 06:28 AM, David Holsgrove wrote: > > d MicroBlaze relocations to elf/elf.h > > > > 2012-11-29 David Holsgrove > > > > * elf/elf.h: Add support for MicroBlaze arch > > > > > > 0002-Adding-MicroBlaze-support-to-elf-elf.h.patch > > >=20 > David, thanks for your patch. Could you please review the Contribution > checklist at http://sourceware.org/glibc/wiki/Contribution%20checklist? >=20 > Your patch misses a valid ChangeLog entry and that's needed for such > changes. Thanks, will update in next version. >=20 > > From 02a0759b648b6aed4538cd0cde88babf5468585a Mon Sep 17 00:00:00 2001 > > From: David Holsgrove > > Date: Wed, 4 Jan 2012 13:56:48 +1000 > > Subject: [PATCH] Adding MicroBlaze support to elf/elf.h > > > > Signed-off-by: David Holsgrove > > --- > > elf/elf.h | 33 +++++++++++++++++++++++++++++++++ > > 1 file changed, 33 insertions(+) > > > > diff --git a/elf/elf.h b/elf/elf.h > > index b07e6ad..6a4a4cc 100644 > > --- a/elf/elf.h > > +++ b/elf/elf.h > > @@ -259,6 +259,8 @@ typedef struct > > chances of collision with official or non-GNU unofficial values. = */ > > > > #define EM_ALPHA 0x9026 > > +#define EM_NEW_MICROBLAZE 0xbd /* Xilinx MicroBlaze */ > > +#define EM_MICROBLAZE 0xbaab >=20 > Are any of these official values? The comment above asks for hig numbers > and 0xbd is not height. >=20 Yes they are, but could be renamed to better match upstream binutils. I'll = revise in this patch for elf.h and also my patch to libc-ports thanks. > > > > /* Legal values for e_version (version). */ > > > > @@ -2847,6 +2849,37 @@ typedef Elf32_Addr Elf32_Conflict; > > #define R_M32R_GOTOFF_LO 64 /* Low 16 bit offset to GOT */ > > #define R_M32R_NUM 256 /* Keep this the last entry. */ > > > > +/* microblaze relocations */ > > +#define R_MICROBLAZE_NONE 0 >=20 > I suggest to be consistent with the writing of the name - so is it > microblaze or MicroBlaze? MicroBlaze :-) Comment updated. >=20 > > +#define R_MICROBLAZE_32 1 > > +#define R_MICROBLAZE_32_PCREL 2 > > +#define R_MICROBLAZE_64_PCREL 3 > > +#define R_MICROBLAZE_32_PCREL_LO 4 > > +#define R_MICROBLAZE_64 5 > > +#define R_MICROBLAZE_32_LO 6 > > +#define R_MICROBLAZE_SRO32 7 > > +#define R_MICROBLAZE_SRW32 8 > > [...] >=20 > Please add comments for all of them, >=20 Thanks for the review, I'll send v2 of my patch shortly. regards, David > Thanks, > Andreas > -- > Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi > SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany > GF: Jeff Hawn,Jennifer Guild,Felix Imend=F6rffer,HRB16746 (AG N=FCrnb= erg) > GPG fingerprint =3D 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A1= 26