From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13125 invoked by alias); 29 Apr 2013 13:31:52 -0000 Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org Received: (qmail 13108 invoked by uid 89); 29 Apr 2013 13:31:51 -0000 X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 X-Spam-User: qpsmtpd, 2 recipients Received: from mail-out.m-online.net (HELO mail-out.m-online.net) (212.18.0.9) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Mon, 29 Apr 2013 13:31:50 +0000 Received: from frontend1.mail.m-online.net (unknown [192.168.8.180]) by mail-out.m-online.net (Postfix) with ESMTP id 3ZzmxJ0S6mz4KKMF; Mon, 29 Apr 2013 15:31:47 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.68]) by mail.m-online.net (Postfix) with ESMTP id 3ZzmxH5kFLzbdHg; Mon, 29 Apr 2013 15:31:47 +0200 (CEST) Received: from mail.mnet-online.de ([192.168.8.180]) by localhost (dynscan1.mail.m-online.net [192.168.6.68]) (amavisd-new, port 10024) with ESMTP id rrzxO5AacqwZ; Mon, 29 Apr 2013 15:31:46 +0200 (CEST) X-Auth-Info: gKX5MhfxT1qk4K19h0dCWf6XJFxymM17anSQILnPm4A= Received: from igel.home (ppp-93-104-141-19.dynamic.mnet-online.de [93.104.141.19]) by mail.mnet-online.de (Postfix) with ESMTPA; Mon, 29 Apr 2013 15:31:46 +0200 (CEST) Received: by igel.home (Postfix, from userid 501) id CB95F112AC0; Mon, 29 Apr 2013 15:31:45 +0200 (CEST) From: Andreas Schwab To: Siddhesh Poyarekar Cc: libc-alpha@sourceware.org, libc-ports@sourceware.org Subject: Re: [PATCH][BZ #14412] Define __sincos_finite as a fast version of sincos References: <20130429102739.GE1330@spoyarek.pnq.redhat.com> X-Yow: If I am elected, the concrete barriers around the WHITE HOUSE will be replaced by tasteful foam replicas of ANN MARGARET! Date: Mon, 29 Apr 2013 13:31:00 -0000 In-Reply-To: <20130429102739.GE1330@spoyarek.pnq.redhat.com> (Siddhesh Poyarekar's message of "Mon, 29 Apr 2013 15:57:40 +0530") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-04/txt/msg00105.txt.bz2 Siddhesh Poyarekar writes: > This patch brings back the assembly implementation of sincos (with > some changes) to give a fast alternative to the default sincos > implementation. This is defined as __sincos_finite and is used if the > implementing program is compiled with the -ffinite-math-only gcc flag. This is the wrong approach. The bug is not about not handling Inf or NaN in sincos, but allowing inaccurate result from certain finite numbers. The -ffinite-math-only switch does not cover the latter. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."